[webkit-changes] [27751] trunk/JavaScriptCore

[Oliver Hunt]

If that assert is firing something is *wrong*

Removing the assert is not safe.

--Oliver

On 13/11/2007, at 9:22 AM, darin at apple.com wrote:

> Revision
> 27751
> Author
> darin at apple.com
> Date
> 2007-11-13 09:22:36 -0800 (Tue, 13 Nov 2007)
> Log Message
>
>         * kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32):
>         Remove too-strong assert that was firing constantly and  
> preventing even basic
>         web browsing from working in a debug build. This function  
> is used in many
>         cases where the immediate value is not a number; the  
> assertion could perhaps
>         be added back later with a bit of reorganization.
> Modified Paths
>
> trunk/JavaScriptCore/ChangeLog
> trunk/JavaScriptCore/kjs/JSImmediate.h
> Diff
>
> Modified: trunk/JavaScriptCore/ChangeLog (27750 => 27751)
>
> --- trunk/JavaScriptCore/ChangeLog	2007-11-13 09:49:50 UTC (rev 27750)
> +++ trunk/JavaScriptCore/ChangeLog	2007-11-13 17:22:36 UTC (rev 27751)
> @@ -1,3 +1,11 @@
> +2007-11-13  Darin Adler  <darin at apple.com>
> +
> +        * kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32):
> +        Remove too-strong assert that was firing constantly and  
> preventing even basic
> +        web browsing from working in a debug build. This function  
> is used in many
> +        cases where the immediate value is not a number; the  
> assertion could perhaps
> +        be added back later with a bit of reorganization.
> +
>  2007-11-13  Alp Toker  <alp at atoker.com>
>
>          Build fix for breakage to non-Mac builds introduced in  
> r27746.
> Modified: trunk/JavaScriptCore/kjs/JSImmediate.h (27750 => 27751)
>
> --- trunk/JavaScriptCore/kjs/JSImmediate.h	2007-11-13 09:49:50 UTC  
> (rev 27750)
> +++ trunk/JavaScriptCore/kjs/JSImmediate.h	2007-11-13 17:22:36 UTC  
> (rev 27751)
> @@ -242,7 +242,6 @@
>
>  ALWAYS_INLINE int32_t JSImmediate::getTruncatedInt32(const  
> JSValue* v)
>  {
> -    ASSERT(isNumber(v));
>      return static_cast<int32_t>(unTag(v)) >> 2;
>  }
>
> _______________________________________________
> webkit-changes mailing list
> webkit-changes at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-changes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.webkit.org/pipermail/webkit-changes/attachments/20071113/9a3f7a49/attachment.html