[webkit-changes] [15089] trunk/WebKit

[Geoffrey Garen]

ha -- i was just going to suggest that!

thanks for fixing my leak

geoff

On Jun 28, 2006, at 5:20 PM, mjs at opensource.apple.com wrote:

> Revision
> 15089
> Author
> mjs
> Date
> 2006-06-28 17:20:12 -0700 (Wed, 28 Jun 2006)
> Log Message
>
>         Reviewed by Anders.
>
>         - fix Frame leak on layout tests
>
>         * WebCoreSupport/WebPageBridge.m:
>         (-[WebPageBridge outerView]): Return WebFrameView for main  
> frame instead
>         of WebView to avoid reference cycle between WebView and Page.
> Modified Paths
>
> trunk/WebKit/ChangeLog
> trunk/WebKit/WebCoreSupport/WebPageBridge.m
> Diff
>
> Modified: trunk/WebKit/ChangeLog (15088 => 15089)
>
> --- trunk/WebKit/ChangeLog	2006-06-28 23:44:03 UTC (rev 15088)
> +++ trunk/WebKit/ChangeLog	2006-06-29 00:20:12 UTC (rev 15089)
> @@ -1,3 +1,13 @@
> +2006-06-28  Maciej Stachowiak  <mjs at apple.com>
> +
> +        Reviewed by Anders.
> +
> +        - fix Frame leak on layout tests
> +
> +        * WebCoreSupport/WebPageBridge.m:
> +        (-[WebPageBridge outerView]): Return WebFrameView for main  
> frame instead
> +        of WebView to avoid reference cycle between WebView and Page.
> +
>  2006-06-28  Timothy Hatcher  <timothy at apple.com>
>
>          Prefer the Stabs debugging symbols format until DWARF bugs  
> are fixed.
> Modified: trunk/WebKit/WebCoreSupport/WebPageBridge.m (15088 => 15089)
>
> --- trunk/WebKit/WebCoreSupport/WebPageBridge.m	2006-06-28 23:44:03  
> UTC (rev 15088)
> +++ trunk/WebKit/WebCoreSupport/WebPageBridge.m	2006-06-29 00:20:12  
> UTC (rev 15089)
> @@ -29,6 +29,7 @@
>  #import "WebPageBridge.h"
>
>  #import "WebFrameBridge.h"
> +#import "WebFrameView.h"
>  #import "WebView.h"
>  #import "WebViewInternal.h"
>  #import <JavaScriptCore/Assertions.h>
> @@ -55,7 +56,7 @@
>
>  - (NSView *)outerView
>  {
> -    return _webView;
> +    return [[_webView mainFrame] frameView];
>  }
>
>  - (void)setWindowFrame:(NSRect)frameRect
> _______________________________________________
> webkit-changes mailing list
> webkit-changes at opendarwin.org
> http://www.opendarwin.org/mailman/listinfo/webkit-changes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/webkit-changes/attachments/20060628/c1d13095/attachment.html