[webkit-changes] cvs commit: WebKit/WebCoreSupport.subproj WebTextRenderer.m

Alexey ap at opensource.apple.com
Sat Jan 7 03:27:18 PST 2006


ap          06/01/07 03:27:17

  Modified:    .        ChangeLog
               fast/text atsui-multiple-renderers-expected.checksum
                        atsui-multiple-renderers-expected.png
                        atsui-multiple-renderers-expected.txt
               .        ChangeLog
               WebCoreSupport.subproj WebTextRenderer.m
  Added:       fast/text
                        atsui-small-caps-punctuation-size-expected.checksum
                        atsui-small-caps-punctuation-size-expected.png
                        atsui-small-caps-punctuation-size-expected.txt
                        atsui-small-caps-punctuation-size.html
  Log:
          Reviewed by Darin, landed by ap.
  
          Test: fast/text/atsui-small-caps-punctuation-size.html
  
          - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6397
            ATSUI small caps use small punctuation
  
          * WebCoreSupport.subproj/WebTextRenderer.m:
          (createATSULayoutParameters): Changed the characters for which size must
          not change from !u_isbase() to the M* categories.
  
  Revision  Changes    Path
  1.234     +15 -0     LayoutTests/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/LayoutTests/ChangeLog,v
  retrieving revision 1.233
  retrieving revision 1.234
  diff -u -r1.233 -r1.234
  --- ChangeLog	6 Jan 2006 20:02:12 -0000	1.233
  +++ ChangeLog	7 Jan 2006 11:27:11 -0000	1.234
  @@ -1,3 +1,18 @@
  +2006-01-07  Mitz Pettel  <opendarwin.org at mitzpettel.com>
  +        
  +        Reviewed by Darin. landed by ap.
  +        
  +        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6397
  +          ATSUI small caps use small punctuation
  +          
  +        * fast/text/atsui-multiple-renderers-expected.checksum: Updated.
  +        * fast/text/atsui-multiple-renderers-expected.png: Updated.
  +        * fast/text/atsui-multiple-renderers-expected.txt: Updated.
  +        * fast/text/atsui-small-caps-punctuation-size-expected.checksum: Added.
  +        * fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
  +        * fast/text/atsui-small-caps-punctuation-size-expected.txt: Added.
  +        * fast/text/atsui-small-caps-punctuation-size.html: Added.
  +
   2006-01-06  Beth Dakin  <bdakin at apple.com>
   
           Reviewed by Geoff.
  
  
  
  1.2       +1 -1      LayoutTests/fast/text/atsui-multiple-renderers-expected.checksum
  
  Index: atsui-multiple-renderers-expected.checksum
  ===================================================================
  RCS file: /cvs/root/LayoutTests/fast/text/atsui-multiple-renderers-expected.checksum,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- atsui-multiple-renderers-expected.checksum	19 Dec 2005 22:16:26 -0000	1.1
  +++ atsui-multiple-renderers-expected.checksum	7 Jan 2006 11:27:11 -0000	1.2
  @@ -1 +1 @@
  -5260ae94c1f3087db913f3c47e1c1aa3
  \ No newline at end of file
  +38f5fa7f03b6884f2cf174b9ef1ae8fe
  \ No newline at end of file
  
  
  
  1.2       +29 -38    LayoutTests/fast/text/atsui-multiple-renderers-expected.png
  
  	<<Binary file>>
  
  
  1.2       +2 -2      LayoutTests/fast/text/atsui-multiple-renderers-expected.txt
  
  Index: atsui-multiple-renderers-expected.txt
  ===================================================================
  RCS file: /cvs/root/LayoutTests/fast/text/atsui-multiple-renderers-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- atsui-multiple-renderers-expected.txt	19 Dec 2005 22:16:26 -0000	1.1
  +++ atsui-multiple-renderers-expected.txt	7 Jan 2006 11:27:12 -0000	1.2
  @@ -87,8 +87,8 @@
                   RenderText {TEXT} at (0,0) size 0x0
               RenderTableRow {TR} at (0,0) size 0x0
                 RenderTableCell {TD} at (0,120) size 132x26 [border: (1px solid #008000)] [r=4 c=0 rs=1 cs=1]
  -                RenderText {TEXT} at (2,2) size 99x23
  -                  text run at (2,2) width 99: "Lore\x{300}m ipsu\x{308}m"
  +                RenderText {TEXT} at (2,2) size 100x23
  +                  text run at (2,2) width 100: "Lore\x{300}m ipsu\x{308}m"
                 RenderTableCell {TD} at (132,120) size 131x26 [border: (1px solid #008000)] [r=4 c=1 rs=1 cs=1]
                   RenderText {TEXT} at (2,2) size 100x23
                     text run at (2,2) width 100: "Lorem ipsum"
  
  
  
  1.1                  LayoutTests/fast/text/atsui-small-caps-punctuation-size-expected.checksum
  
  Index: atsui-small-caps-punctuation-size-expected.checksum
  ===================================================================
  6c82762a79da38e361acd8c113dc8b44
  \ No newline at end of file
  
  
  
  1.1                  LayoutTests/fast/text/atsui-small-caps-punctuation-size-expected.png
  
  	<<Binary file>>
  
  
  1.1                  LayoutTests/fast/text/atsui-small-caps-punctuation-size-expected.txt
  
  Index: atsui-small-caps-punctuation-size-expected.txt
  ===================================================================
  layer at (0,0) size 800x600
    RenderCanvas at (0,0) size 800x600
  layer at (0,0) size 800x600
    RenderBlock {HTML} at (0,0) size 800x600
      RenderBody {BODY} at (8,8) size 784x576
        RenderBlock {P} at (0,0) size 784x36
          RenderText {TEXT} at (0,0) size 212x18
            text run at (0,0) width 212: "This tests for a regression against "
          RenderInline {I} at (0,0) size 742x36
            RenderInline {A} at (0,0) size 348x18 [color=#0000EE]
              RenderText {TEXT} at (212,0) size 348x18
                text run at (212,0) width 348: "http://bugzilla.opendarwin.org/show_bug.cgi?id=6397"
            RenderText {TEXT} at (560,0) size 742x36
              text run at (560,0) width 182: " ATSUI small caps use small"
              text run at (0,18) width 75: "punctuation"
          RenderText {TEXT} at (75,18) size 4x18
            text run at (75,18) width 4: "."
        RenderBlock {P} at (0,52) size 784x18
          RenderText {TEXT} at (0,0) size 367x18
            text run at (0,0) width 367: "All four question marks below should be \x{201C}big\x{201D}, like this: ?"
        RenderBlock {HR} at (0,86) size 784x2 [border: (1px inset #000000)]
        RenderBlock {P} at (0,104) size 784x18
          RenderText {TEXT} at (0,0) size 56x18
            text run at (0,0) width 56: "ATSUI: "
          RenderInline {SPAN} at (0,0) size 40x18
            RenderText {TEXT} at (56,0) size 40x18
              text run at (56,0) width 40: "A?b?e\x{300}"
        RenderBlock {P} at (0,138) size 784x18
          RenderText {TEXT} at (0,0) size 31x18
            text run at (0,0) width 31: "CG: "
          RenderInline {SPAN} at (0,0) size 40x18
            RenderText {TEXT} at (31,0) size 40x18
              text run at (31,0) width 40: "A?b?e"
  
  
  
  1.1                  LayoutTests/fast/text/atsui-small-caps-punctuation-size.html
  
  Index: atsui-small-caps-punctuation-size.html
  ===================================================================
  <html>
  <head>
  <title>ATSUI small-caps punctuation</title>
  </head>
  <body>
  <p>
  This tests for a regression against
  <i><a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=6397">http://bugzilla.opendarwin.org/show_bug.cgi?id=6397</a>
  ATSUI small caps use small punctuation</i>.
  </p>
  <p>
  All four question marks below should be &ldquo;big&rdquo;, like this: ?
  </p>
  <hr>
  <p>ATSUI: <span style="font-variant: small-caps;">A?b?e&#x0300;</span></p>
  <p>CG: <span style="font-variant: small-caps;">A?b?e</span></p>
  </body>
  </html>
  
  
  
  1.3448    +13 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3447
  retrieving revision 1.3448
  diff -u -r1.3447 -r1.3448
  --- ChangeLog	6 Jan 2006 21:09:43 -0000	1.3447
  +++ ChangeLog	7 Jan 2006 11:27:13 -0000	1.3448
  @@ -1,3 +1,16 @@
  +2006-01-07  Mitz Pettel  <opendarwin.org at mitzpettel.com>
  +
  +        Reviewed by Darin, landed by ap.
  +        
  +        Test: fast/text/atsui-small-caps-punctuation-size.html
  +        
  +        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6397
  +          ATSUI small caps use small punctuation
  +          
  +        * WebCoreSupport.subproj/WebTextRenderer.m:
  +        (createATSULayoutParameters): Changed the characters for which size must
  +        not change from !u_isbase() to the M* categories.
  +
   2006-01-06  John Sullivan  <sullivan at apple.com>
   
           Reviewed by Vicki Murley (full credit) and Tim Omernick (half credit).
  
  
  
  1.215     +1 -1      WebKit/WebCoreSupport.subproj/WebTextRenderer.m
  
  Index: WebTextRenderer.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebTextRenderer.m,v
  retrieving revision 1.214
  retrieving revision 1.215
  diff -u -r1.214 -r1.215
  --- WebTextRenderer.m	4 Jan 2006 02:01:42 -0000	1.214
  +++ WebTextRenderer.m	7 Jan 2006 11:27:17 -0000	1.215
  @@ -1386,7 +1386,7 @@
               if (style->smallCaps) {
                   UniChar c = charBuffer[i];
                   UniChar newC;
  -                if (!u_isbase(c))
  +                if (U_GET_GC_MASK(c) & U_GC_M_MASK)
                       renderers[i] = isSmallCap ? getSmallCapsRenderer(r) : r;
                   else if (!u_isUUppercase(c) && (newC = u_toupper(c)) != c) {
                       charBuffer[i] = newC;
  
  
  



More information about the webkit-changes mailing list