[webkit-changes] cvs commit: JavaScriptCore/pcre pcre.h pcre_compile.c pcre_exec.c

[George Staikos]

On Friday 06 January 2006 17:43, David wrote:
>   -  tm t;
>   -  utc ? gmtime_r(&tv, &t) : localtime_r(&tv, &t);
>   +  tm t = *(utc ? gmtime(&tv) : localtime(&tv));
>      // We had an out of range year. Restore the year (plus/minus offset
>      // found by calculating tm_year) and fix the week day calculation.
>      if (realYearOffset != 0) {
>   @@ -769,8 +779,7 @@
>    JSValue *DateObjectImp::callAsFunction(ExecState * /*exec*/, JSObject *
> /*thisObj*/, const List &/*args*/) {
>        time_t t = time(0);
>   -    tm ts;
>   -    localtime_r(&t, &ts);
>   +    tm ts = *localtime(&t);
>        return jsString(formatDate(ts) + " " + formatTime(ts));
>    }
>
>   @@ -899,8 +908,7 @@
>        // produce incorrect results, but there's no other option when
> calling localtime_r(). if (!utc) {
>            time_t tval = mktime(t) + (time_t)((ms + yearOffset) / 1000);
>   -        struct tm t3;
>   -        localtime_r(&tval, &t3);
>   +        tm t3 = *localtime(&tval);
>            t->tm_isdst = t3.tm_isdst;
>        }

   These look quite questionable to me.  Is threadsafety not a goal anymore?

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/