[webkit-changes] cvs commit: WebCore/kwq KWQKHTMLPart.mm
Geoffrey
ggaren at opensource.apple.com
Fri Jan 6 11:24:07 PST 2006
ggaren 06/01/06 11:24:07
Modified: . ChangeLog
kwq KWQKHTMLPart.mm
Added: manual-tests empty-link-target.html
Log:
Patch by Mitz, reviwed by Darin, layout tested and landed by me.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6382
REGRESSION: Repro crash when clicking link with target="_blank"
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::setName):
* manual-tests/empty-link-target.html: Added.
Revision Changes Path
1.95 +11 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.94
retrieving revision 1.95
diff -u -r1.94 -r1.95
--- ChangeLog 6 Jan 2006 15:50:50 -0000 1.94
+++ ChangeLog 6 Jan 2006 19:24:03 -0000 1.95
@@ -1,3 +1,14 @@
+2006-01-06 Geoffrey Garen <ggaren at apple.com>
+
+ Patch by Mitz, reviwed by Darin, layout tested and landed by me.
+
+ - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6382
+ REGRESSION: Repro crash when clicking link with target="_blank"
+
+ * kwq/KWQKHTMLPart.mm:
+ (KWQKHTMLPart::setName):
+ * manual-tests/empty-link-target.html: Added.
+
2006-01-06 Alexey Proskuryakov <ap at nypop.com>
Reviewed by Darin.
1.1 WebCore/manual-tests/empty-link-target.html
Index: empty-link-target.html
===================================================================
<html>
<head><script>
function print(message) {
var paragraph = document.createElement("p");
paragraph.appendChild(document.createTextNode(message));
document.getElementById("console").appendChild(paragraph);
}
function test()
{
if (window.layoutTestController)
layoutTestController.dumpAsText();
var e = document.createEvent("MouseEvents");
e.initEvent("click", true, false);
document.getElementById('a').dispatchEvent(e);
print("PASS");
}
</script></head>
<body onload="test()">
<p>Bug: <a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=6382">REGRESSION: Repro crash when clicking link with target="_blank"</a></p>
<p>If the test passes, you will see a PASS message below. (It's normal for a new window to open.)</p>
<hr>
<a id="a" href="resources/popup200x200.html" target="_blank"></a>
<div id='console'/>
</body>
</html>
1.715 +1 -1 WebCore/kwq/KWQKHTMLPart.mm
Index: KWQKHTMLPart.mm
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQKHTMLPart.mm,v
retrieving revision 1.714
retrieving revision 1.715
diff -u -r1.714 -r1.715
--- KWQKHTMLPart.mm 5 Jan 2006 06:41:23 -0000 1.714
+++ KWQKHTMLPart.mm 6 Jan 2006 19:24:04 -0000 1.715
@@ -3826,7 +3826,7 @@
KWQKHTMLPart *parent = KWQ(parentPart());
// FIXME: is the blank rule needed or useful?
- if (parent && (name.isEmpty() || parent->frameExists(name)) || name == "_blank")
+ if (parent && (name.isEmpty() || parent->frameExists(name) || name == "_blank"))
n = parent->requestFrameName();
KHTMLPart::setName(n);
More information about the webkit-changes
mailing list