[webkit-changes] cvs commit: WebKit/WebView.subproj WebPDFView.m

[John]

sullivan    06/01/05 16:12:04

  Modified:    .        ChangeLog
               WebView.subproj WebPDFView.m
  Log:
          * WebView.subproj/WebPDFView.m:
          (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
          Just added a FIXME comment about how to clean up this minor hack in the future.
  
  Revision  Changes    Path
  1.3445    +6 -0      WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3444
  retrieving revision 1.3445
  diff -u -r1.3444 -r1.3445
  --- ChangeLog	5 Jan 2006 23:57:04 -0000	1.3444
  +++ ChangeLog	6 Jan 2006 00:11:53 -0000	1.3445
  @@ -1,5 +1,11 @@
   2006-01-05  John Sullivan  <sullivan at apple.com>
   
  +        * WebView.subproj/WebPDFView.m:
  +        (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
  +        Just added a FIXME comment about how to clean up this minor hack in the future.
  +
  +2006-01-05  John Sullivan  <sullivan at apple.com>
  +
           Reviewed by Tim O.
           
           - fixed these bugs:
  
  
  
  1.34      +2 -0      WebKit/WebView.subproj/WebPDFView.m
  
  Index: WebPDFView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebPDFView.m,v
  retrieving revision 1.33
  retrieving revision 1.34
  diff -u -r1.33 -r1.34
  --- WebPDFView.m	5 Jan 2006 23:57:11 -0000	1.33
  +++ WebPDFView.m	6 Jan 2006 00:12:03 -0000	1.34
  @@ -501,6 +501,8 @@
   
   - (NSEvent *)_fakeKeyEventWithFunctionKey:(unichar)functionKey
   {
  +    // FIXME 4400480: when PDFView implements the four standard scrolling selectors that this
  +    // method is used to mimic, we can eliminate this method and call them directly.
       NSString *keyAsString = [NSString stringWithCharacters:&functionKey length:1];
       return [NSEvent keyEventWithType:NSKeyDown
                               location:NSZeroPoint