[webkit-changes] cvs commit: WebCore/khtml/ecma kjs_window.cpp
Justin
justing at opensource.apple.com
Tue Jan 3 15:21:23 PST 2006
justing 06/01/03 15:21:22
Modified: . ChangeLog
khtml/ecma kjs_window.cpp
Log:
Reviewed by harrison
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
window.getSelection().toString() is undefined (range object
returned from window.getSelection() is useless)
toString was defined as a method on the JS Selection object,
but it didn't return anything.
Added layout test:
* editing/selection/toString.html
* khtml/ecma/kjs_window.cpp:
(KJS::SelectionFunc::callAsFunction):
Revision Changes Path
1.82 +17 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -r1.81 -r1.82
--- ChangeLog 3 Jan 2006 22:42:48 -0000 1.81
+++ ChangeLog 3 Jan 2006 23:21:21 -0000 1.82
@@ -1,3 +1,20 @@
+2006-01-03 Justin Garcia <justin.garcia at apple.com>
+
+ Reviewed by harrison
+
+ <http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
+ window.getSelection().toString() is undefined (range object
+ returned from window.getSelection() is useless)
+
+ toString was defined as a method on the JS Selection object,
+ but it didn't return anything.
+
+ Added layout test:
+ * editing/selection/toString.html
+
+ * khtml/ecma/kjs_window.cpp:
+ (KJS::SelectionFunc::callAsFunction):
+
2006-01-03 Geoffrey Garen <ggaren at apple.com>
Reviewed by timo.
1.210 +2 -1 WebCore/khtml/ecma/kjs_window.cpp
Index: kjs_window.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/ecma/kjs_window.cpp,v
retrieving revision 1.209
retrieving revision 1.210
diff -u -r1.209 -r1.210
--- kjs_window.cpp 3 Jan 2006 12:28:24 -0000 1.209
+++ kjs_window.cpp 3 Jan 2006 23:21:21 -0000 1.210
@@ -2422,7 +2422,8 @@
break;
case Selection::GetRangeAt:
return getDOMRange(exec, s.getRangeAt(args[0]->toInt32(exec)).get());
- break;
+ case Selection::ToString:
+ return jsString(s.toString());
}
part->setSelection(s);
More information about the webkit-changes
mailing list