[webkit-changes] cvs commit: WebCore/kwq KWQKHTMLPart.mm

[Geoffrey]

ggaren      06/01/03 14:42:51

  Modified:    .        ChangeLog
               kwq      KWQKHTMLPart.mm
  Log:
          Reviewed by timo.
  
          - Fixed: http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
          REGRESSION: Repro crash in JS called from Flash on bdash.net.nz
  
          Since we clear all the plugin data structures in setView, we need to
          clear the windowScriptObject as well. I had already done this in my
          previous patch, but I didn't realize there are two windowScriptObjects
          -- one for Netscape PlugIns, and one for WebKit PlugIns.
  
          * kwq/KWQKHTMLPart.mm:
          (KWQKHTMLPart::setView): Clear the Netscape PlugIn windowScriptObject
          as well.
  
  Revision  Changes    Path
  1.81      +16 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.80
  retrieving revision 1.81
  diff -u -r1.80 -r1.81
  --- ChangeLog	3 Jan 2006 22:34:19 -0000	1.80
  +++ ChangeLog	3 Jan 2006 22:42:48 -0000	1.81
  @@ -1,3 +1,19 @@
  +2006-01-03  Geoffrey Garen  <ggaren at apple.com>
  +
  +        Reviewed by timo.
  +
  +        - Fixed: http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
  +        REGRESSION: Repro crash in JS called from Flash on bdash.net.nz
  +
  +        Since we clear all the plugin data structures in setView, we need to
  +        clear the windowScriptObject as well. I had already done this in my
  +        previous patch, but I didn't realize there are two windowScriptObjects 
  +        -- one for Netscape PlugIns, and one for WebKit PlugIns.
  +
  +        * kwq/KWQKHTMLPart.mm:
  +        (KWQKHTMLPart::setView): Clear the Netscape PlugIn windowScriptObject
  +        as well.
  +
   2006-01-03  Anders Carlsson  <andersca at mac.com>
   
           Reviewed by Eric.
  
  
  
  1.713     +1 -0      WebCore/kwq/KWQKHTMLPart.mm
  
  Index: KWQKHTMLPart.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQKHTMLPart.mm,v
  retrieving revision 1.712
  retrieving revision 1.713
  diff -u -r1.712 -r1.713
  --- KWQKHTMLPart.mm	29 Dec 2005 10:36:23 -0000	1.712
  +++ KWQKHTMLPart.mm	3 Jan 2006 22:42:48 -0000	1.713
  @@ -801,6 +801,7 @@
       _bindingRoot = 0;
       KWQRelease(_windowScriptObject);
       _windowScriptObject = 0;
  +    _windowScriptNPObject = 0;
       
       // Only one form submission is allowed per view of a part.
       // Since this part may be getting reused as a result of being