[webkit-changes] cvs commit: WebKit/WebView.subproj WebFrame.m

[Anders]

andersca    06/01/03 13:50:20

  Modified:    .        ChangeLog
               WebView.subproj WebFrame.m
  Log:
  2006-01-03  Anders Carlsson  <andersca at mac.com>
  
          Reviewed by Darin.
  
          - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6357
          REGRESSION: iframe and target is broken
  
          * WebView.subproj/WebFrame.m:
          (-[WebFrame _descendantFrameNamed:sourceFrame:]):
          Return the correct frame.
  
  Revision  Changes    Path
  1.3439    +16 -5     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3438
  retrieving revision 1.3439
  diff -u -r1.3438 -r1.3439
  --- ChangeLog	3 Jan 2006 05:15:15 -0000	1.3438
  +++ ChangeLog	3 Jan 2006 21:50:12 -0000	1.3439
  @@ -1,13 +1,24 @@
  +2006-01-03  Anders Carlsson  <andersca at mac.com>
  +
  +        Reviewed by Darin.
  +
  +        - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6357
  +        REGRESSION: iframe and target is broken
  +        
  +        * WebView.subproj/WebFrame.m:
  +        (-[WebFrame _descendantFrameNamed:sourceFrame:]):
  +        Return the correct frame.
  +
   2006-01-02  Maciej Stachowiak  <mjs at apple.com>
   
           Reviewed by Eric.
   
  -	- moved frame traversal logic from WebFrame to WebBridge
  -	http://bugzilla.opendarwin.org/show_bug.cgi?id=6341
  +	    - moved frame traversal logic from WebFrame to WebBridge
  +	    http://bugzilla.opendarwin.org/show_bug.cgi?id=6341
   
  -	To do this, I had to invert the ownership so that WebBridge now
  -	owns WebFrame instead of vice versa. As a result, WebView now owns
  -	a WebBridge pointer and does not have a direct WebFrame pointer.
  +	    To do this, I had to invert the ownership so that WebBridge now
  +	    owns WebFrame instead of vice versa. As a result, WebView now owns
  +	    a WebBridge pointer and does not have a direct WebFrame pointer.
   
           * WebCoreSupport.subproj/WebBridge.h:
           * WebCoreSupport.subproj/WebBridge.m:
  
  
  
  1.269     +1 -1      WebKit/WebView.subproj/WebFrame.m
  
  Index: WebFrame.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebFrame.m,v
  retrieving revision 1.268
  retrieving revision 1.269
  diff -u -r1.268 -r1.269
  --- WebFrame.m	3 Jan 2006 05:15:21 -0000	1.268
  +++ WebFrame.m	3 Jan 2006 21:50:19 -0000	1.269
  @@ -3150,7 +3150,7 @@
           // for security reasons, we do not want to even make frames visible to frames that
           // can't access them 
           if ([[frame name] isEqualToString:name] && [frame _shouldAllowAccessFrom:source])
  -            return self;
  +            return frame;
   
       return nil;
   }