[webkit-changes] cvs commit: JavaScriptCore/kjs internal.cpp

[Geoffrey]

ggaren      05/09/20 17:25:11

  Modified:    .        ChangeLog
               kjs      internal.cpp
  Log:
          - Fixed <rdar://problem/4263434> <rdar://problem/4263434> Denver 8F29 Regression:
            KJS::InterpreterImp::mark() crash
  
          Fix by mjs, review by me.
  
          * kjs/internal.cpp:
          (KJS::InterpreterImp::mark): Added a null check on globExec in case a
          garbage collection occurs inside InterpreterImp::globalInit (called
          from InterpreterImp::InterpreterImp), at which point globExec has not yet been initialized.
  
  Revision  Changes    Path
  1.831     +12 -0     JavaScriptCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
  retrieving revision 1.830
  retrieving revision 1.831
  diff -u -r1.830 -r1.831
  --- ChangeLog	20 Sep 2005 08:10:35 -0000	1.830
  +++ ChangeLog	21 Sep 2005 00:25:10 -0000	1.831
  @@ -1,5 +1,17 @@
   2005-09-20  Geoffrey Garen  <ggaren at apple.com>
   
  +        - Fixed <rdar://problem/4263434> <rdar://problem/4263434> Denver 8F29 Regression:
  +          KJS::InterpreterImp::mark() crash
  +          
  +        Fix by mjs, review by me.
  +
  +        * kjs/internal.cpp:
  +        (KJS::InterpreterImp::mark): Added a null check on globExec in case a
  +        garbage collection occurs inside InterpreterImp::globalInit (called
  +        from InterpreterImp::InterpreterImp), at which point globExec has not yet been initialized.
  +
  +2005-09-20  Geoffrey Garen  <ggaren at apple.com>
  +
           - Rolled in fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4892
             Date constructor has problems with months larger than 11
   
  
  
  
  1.71      +1 -1      JavaScriptCore/kjs/internal.cpp
  
  Index: internal.cpp
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/kjs/internal.cpp,v
  retrieving revision 1.70
  retrieving revision 1.71
  diff -u -r1.70 -r1.71
  --- internal.cpp	19 Sep 2005 06:57:27 -0000	1.70
  +++ internal.cpp	21 Sep 2005 00:25:11 -0000	1.71
  @@ -644,7 +644,7 @@
       _context->mark();
     if (global)
         global->mark();
  -  if (globExec._exception)
  +  if (globExec && globExec._exception)
         globExec._exception->mark();
   }