[webkit-changes] cvs commit: WebCore/khtml/xml dom_nodeimpl.cpp

[Beth]

bdakin      05/09/20 16:59:05

  Modified:    .        ChangeLog
               khtml/xml dom_nodeimpl.cpp
  Log:
  Bug #:
  
  Revision  Changes    Path
  1.142     +13 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.141
  retrieving revision 1.142
  diff -u -r1.141 -r1.142
  --- ChangeLog	20 Sep 2005 23:38:50 -0000	1.141
  +++ ChangeLog	20 Sep 2005 23:59:04 -0000	1.142
  @@ -1,5 +1,18 @@
   2005-09-20  Beth Dakin  <bdakin at apple.com>
   
  +        Reviewed by Darin
  +
  +        Test cases added: (NONE)
  +
  +	Fixing the fix I submitted a few minutes ago for <rdar://problem/4039660>
  +	The case this extra fix safeguards against will probably never occur, but
  +	it makes the code safer. 
  +
  +        * khtml/xml/dom_nodeimpl.cpp: Send newChild to traverseNextNode()
  +        (DOM::NodeImpl::checkAddChild):
  +
  +2005-09-20  Beth Dakin  <bdakin at apple.com>
  +
           Reviewed by Hyatt
   
           Test cases added: /fast/dom/replaceChild.html
  
  
  
  1.192     +1 -1      WebCore/khtml/xml/dom_nodeimpl.cpp
  
  Index: dom_nodeimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_nodeimpl.cpp,v
  retrieving revision 1.191
  retrieving revision 1.192
  diff -u -r1.191 -r1.192
  --- dom_nodeimpl.cpp	20 Sep 2005 23:38:51 -0000	1.191
  +++ dom_nodeimpl.cpp	20 Sep 2005 23:59:05 -0000	1.192
  @@ -1140,7 +1140,7 @@
   
       // change the document pointer of newChild and all of its children to be the new document
       if (shouldAdoptChild) {
  -        for (NodeImpl* node = newChild; node; node = node->traverseNextNode()) {
  +        for (NodeImpl* node = newChild; node; node = node->traverseNextNode(newChild)) {
               KJS::ScriptInterpreter::updateDOMNodeDocument(node, node->getDocument(), getDocument());
               node->setDocument(getDocument()->docPtr());
           }