[webkit-changes] cvs commit: WebKit/WebView.subproj WebImageView.m

[John]

sullivan    05/09/16 16:55:21

  Modified:    .        ChangeLog
               WebView.subproj WebImageView.m
  Log:
          Reviewed by Tim Omernick
  
          - fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at
          com.apple.AppKit: -[NSPasteboard setData:forType:] + 188
  
          * WebView.subproj/WebImageView.m:
          (-[WebImageView copy:]):
          declare types to pasteboard before starting to set their data
          (-[WebImageView writeSelectionToPasteboard:types:]):
          ditto
  
  Revision  Changes    Path
  1.3324    +13 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3323
  retrieving revision 1.3324
  diff -u -r1.3323 -r1.3324
  --- ChangeLog	16 Sep 2005 23:09:55 -0000	1.3323
  +++ ChangeLog	16 Sep 2005 23:55:18 -0000	1.3324
  @@ -1,3 +1,16 @@
  +2005-09-16  John Sullivan  <sullivan at apple.com>
  +
  +        Reviewed by Tim Omernick
  +        
  +        - fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at 
  +        com.apple.AppKit: -[NSPasteboard setData:forType:] + 188
  +
  +        * WebView.subproj/WebImageView.m:
  +        (-[WebImageView copy:]):
  +        declare types to pasteboard before starting to set their data
  +        (-[WebImageView writeSelectionToPasteboard:types:]):
  +        ditto
  +
   2005-09-16  Adele Peterson  <adele at apple.com>
   
           Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
  
  
  
  1.73      +4 -1      WebKit/WebView.subproj/WebImageView.m
  
  Index: WebImageView.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebImageView.m,v
  retrieving revision 1.72
  retrieving revision 1.73
  diff -u -r1.72 -r1.73
  --- WebImageView.m	22 Jun 2005 21:32:09 -0000	1.72
  +++ WebImageView.m	16 Sep 2005 23:55:21 -0000	1.73
  @@ -224,11 +224,14 @@
   
   - (void)copy:(id)sender
   {
  -    [self writeImageToPasteboard:[NSPasteboard generalPasteboard] types:[NSPasteboard _web_writableTypesForImageIncludingArchive:([rep archive] != nil)]];
  +    NSArray *types = [NSPasteboard _web_writableTypesForImageIncludingArchive:([rep archive] != nil)];
  +    [pasteboard declareTypes:types owner:nil];
  +    [self writeImageToPasteboard:[NSPasteboard generalPasteboard] types:types];
   }
   
   - (BOOL)writeSelectionToPasteboard:(NSPasteboard *)pasteboard types:(NSArray *)types
   {
  +    [pasteboard declareTypes:types owner:nil];
       return [self writeImageToPasteboard:pasteboard types:types];
   }