[webkit-changes] cvs commit: WebCore/manual-tests/resources
spinbox.swf
Tim
tomernic at opensource.apple.com
Fri Sep 16 11:55:11 PDT 2005
tomernic 05/09/16 11:55:11
Modified: . ChangeLog
khtml/html html_objectimpl.cpp
Added: manual-tests show-hide-object.html
manual-tests/resources spinbox.swf
Log:
Reviewed by Dave Hyatt. Test case reviewed by Vicki Murley.
<rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)
Test cases added:
* manual-tests/show-hide-object.html: Added.
* manual-tests/resources/spinbox.swf: Added.
* khtml/html/html_objectimpl.cpp:
(DOM::HTMLObjectElementImpl::detach):
Set needWidgetUpdate to true so that the widget is updated on the next attach().
Revision Changes Path
1.128 +14 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.127
retrieving revision 1.128
diff -u -r1.127 -r1.128
--- ChangeLog 16 Sep 2005 06:36:17 -0000 1.127
+++ ChangeLog 16 Sep 2005 18:55:09 -0000 1.128
@@ -1,3 +1,17 @@
+2005-09-16 Tim Omernick <tomernick at apple.com>
+
+ Reviewed by Dave Hyatt. Test case reviewed by Vicki Murley.
+
+ <rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)
+
+ Test cases added:
+ * manual-tests/show-hide-object.html: Added.
+ * manual-tests/resources/spinbox.swf: Added.
+
+ * khtml/html/html_objectimpl.cpp:
+ (DOM::HTMLObjectElementImpl::detach):
+ Set needWidgetUpdate to true so that the widget is updated on the next attach().
+
2005-09-15 Eric Seidel <eseidel at apple.com>
Reviewed by mjs.
1.78 +5 -1 WebCore/khtml/html/html_objectimpl.cpp
Index: html_objectimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_objectimpl.cpp,v
retrieving revision 1.77
retrieving revision 1.78
diff -u -r1.77 -r1.78
--- html_objectimpl.cpp 31 Aug 2005 04:38:38 -0000 1.77
+++ html_objectimpl.cpp 16 Sep 2005 18:55:10 -0000 1.78
@@ -765,9 +765,13 @@
void HTMLObjectElementImpl::detach()
{
// Only bother with an unload event if we had a render object. - dwh
- if (attached() && m_render && !m_useFallbackContent)
+ if (attached() && m_render && !m_useFallbackContent) {
// ### do this when we are actualy removed from document instead
dispatchHTMLEvent(unloadEvent,false,false);
+
+ // Update the widget the next time we attach (detaching destroys the plugin).
+ needWidgetUpdate = true;
+ }
HTMLElementImpl::detach();
}
1.1 WebCore/manual-tests/show-hide-object.html
Index: show-hide-object.html
===================================================================
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">
<html lang="en">
<head>
</head>
<body>
<p><b>BUG ID:</b> <a href="rdar://problem/3572507">3572507</a> Flash in div with display:none style will not redraw when style changed to display:block (3479)</p>
<p id="test" style="background-color:skyblue; padding:3px;"><b>STEPS TO TEST:</b> <br>
1. Verify that there is a Flash animation playing below.<br>
2. Click "Hide Flash".<br>
3. Click "Show Flash".<br>
</p>
<p id="success" style="background-color:palegreen; padding:3px;"><b>TEST PASS:</b>
The Flash movie hides when "Hide Flash" is clicked, and shows again when "Show Flash" is clicked.
</p>
<p id="failure" style="background-color:#FF3300; padding:3px;"><b>TEST FAIL:</b>
The Flash movie hides when "Hide Flash" is clicked, but does not show again when "Show Flash" is clicked. Clicking on "Hide Flash" and then "Show Flash" again will show the movie.
</p>
<script language="JavaScript">
// 2 html tabs for multiple flash/java
var selected = "tab1";
function tabClick(whichTab) {
selected = whichTab;
if (whichTab == "tab1") {
document.getElementById('tab1').style.display = "block";
document.getElementById('tab2').style.display = "none";
}
else if (whichTab == "tab2") {
document.getElementById('tab2').style.display = "block";
document.getElementById('tab1').style.display = "none";
}
}
</script>
<div>
<input type=button value="Hide Flash" onClick="tabClick('tab2')"><input type=button value="Show Flash" onClick="tabClick('tab1')">
<div id="tab2" style="display: none">
Flash hidden.
</div>
<div id="tab1">
<object id="scopeFlash" classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" width="300" height="200" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,0,0">
<param name="movie" value="resources/spinbox.swf">
<param name="quality" value="high">
<comment>
<embed src="resources/spinbox.swf" width="300" height="200" quality="high" pluginspage="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash">
</embed>
</comment>
</object>
</div>
</div>
</body>
</html>
1.1 WebCore/manual-tests/resources/spinbox.swf
<<Binary file>>
More information about the webkit-changes
mailing list