[webkit-changes] cvs commit: WebCore/khtml/xml dom_docimpl.cpp

[Vicki]

vicki       05/09/01 17:19:30

  Modified:    .        ChangeLog
               khtml/xml dom_docimpl.cpp
  Log:
          Reviewed by John.
  
          Test cases added: No new tests, HTMLFrameElement09.html covers this crash
  
  	- fixed <rdar://problem/4224088> crash in KWQKHTMLPart::handledOnloadEvents loading test HTMLFrameElement09.html
  
          * khtml/xml/dom_docimpl.cpp:
          (DocumentImpl::implicitClose): nil check on the part
  
  Revision  Changes    Path
  1.74      +11 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.73
  retrieving revision 1.74
  diff -u -r1.73 -r1.74
  --- ChangeLog	1 Sep 2005 23:40:35 -0000	1.73
  +++ ChangeLog	2 Sep 2005 00:19:26 -0000	1.74
  @@ -1,3 +1,14 @@
  +2005-09-01  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by John.
  + 
  +        Test cases added: No new tests, HTMLFrameElement09.html covers this crash
  +
  +	- fixed <rdar://problem/4224088> crash in KWQKHTMLPart::handledOnloadEvents loading test HTMLFrameElement09.html
  +
  +        * khtml/xml/dom_docimpl.cpp:
  +        (DocumentImpl::implicitClose): nil check on the part
  +
   2005-09-01  Darin Adler  <darin at apple.com>
   
           Reviewed by Maciej.
  
  
  
  1.251     +2 -1      WebCore/khtml/xml/dom_docimpl.cpp
  
  Index: dom_docimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_docimpl.cpp,v
  retrieving revision 1.250
  retrieving revision 1.251
  diff -u -r1.250 -r1.251
  --- dom_docimpl.cpp	31 Aug 2005 04:38:41 -0000	1.250
  +++ dom_docimpl.cpp	2 Sep 2005 00:19:29 -0000	1.251
  @@ -1348,7 +1348,8 @@
               dispatchImageLoadEventsNow();
               body->dispatchWindowEvent(loadEvent, false, false);
   #if APPLE_CHANGES
  -            KWQ(part())->handledOnloadEvents();
  +            if (KHTMLPart *p = part())
  +                KWQ(p)->handledOnloadEvents();
   #endif
   
   #ifdef INSTRUMENT_LAYOUT_SCHEDULING