[webkit-changes] cvs commit: WebCore/khtml/rendering render_layer.cpp

[Adele]

adele       05/10/27 10:39:38

  Modified:    .        ChangeLog
               khtml    khtml_part.cpp
               khtml/rendering render_layer.cpp
  Log:
          Reviewed by Vicki.
  
          - fixed <rdar://problem/4318167> REGRESSION: content doesn't scroll far enough to the left after clicking links at aplacecalledcommon.co.uk
  
          * khtml/rendering/render_layer.cpp:
          (khtml::RenderLayer::scrollRectToVisible): fixed a typo where verticalAlignment was being passed instead of horizontalAlignment.
          * khtml/khtml_part.cpp:
          (KHTMLPart::gotoAnchor): specified alignLeft as horizontal alignment.
  
  Revision  Changes    Path
  1.302     +11 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.301
  retrieving revision 1.302
  diff -u -r1.301 -r1.302
  --- ChangeLog	27 Oct 2005 09:30:32 -0000	1.301
  +++ ChangeLog	27 Oct 2005 17:39:32 -0000	1.302
  @@ -1,3 +1,14 @@
  +2005-10-27  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by Vicki.
  +
  +        - fixed <rdar://problem/4318167> REGRESSION: content doesn't scroll far enough to the left after clicking links at aplacecalledcommon.co.uk
  +
  +        * khtml/rendering/render_layer.cpp: 
  +        (khtml::RenderLayer::scrollRectToVisible): fixed a typo where verticalAlignment was being passed instead of horizontalAlignment.
  +        * khtml/khtml_part.cpp: 
  +        (KHTMLPart::gotoAnchor): specified alignLeft as horizontal alignment.
  +
   2005-10-27  David Hyatt  <hyatt at apple.com>
   
   	Fix form controls so that they can take advantage of
  
  
  
  1.353     +1 -1      WebCore/khtml/khtml_part.cpp
  
  Index: khtml_part.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/khtml_part.cpp,v
  retrieving revision 1.352
  retrieving revision 1.353
  diff -u -r1.352 -r1.353
  --- khtml_part.cpp	26 Oct 2005 21:47:35 -0000	1.352
  +++ khtml_part.cpp	27 Oct 2005 17:39:35 -0000	1.353
  @@ -2311,7 +2311,7 @@
       khtml::RenderLayer *layer =  d->m_doc->renderer()->enclosingLayer();
       if (layer)
           // We used to align to the top left corner, but now, if the anchor is already horizontally visible, we won't scroll horizontally.
  -        d->m_doc->renderer()->enclosingLayer()->scrollRectToVisible(QRect(x, y, 0, 0), alignTop);
  +        d->m_doc->renderer()->enclosingLayer()->scrollRectToVisible(QRect(x, y, 0, 0), alignTop, alignLeft);
     }
   #else
     d->m_view->setContentsPos(x, y);
  
  
  
  1.120     +1 -1      WebCore/khtml/rendering/render_layer.cpp
  
  Index: render_layer.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_layer.cpp,v
  retrieving revision 1.119
  retrieving revision 1.120
  diff -u -r1.119 -r1.120
  --- render_layer.cpp	26 Oct 2005 21:47:37 -0000	1.119
  +++ render_layer.cpp	27 Oct 2005 17:39:37 -0000	1.120
  @@ -573,7 +573,7 @@
           QScrollView* view = m_object->document()->view();
           QRect viewRect = QRect(view->contentsX(), view->contentsY(), view->visibleWidth(), view->visibleHeight());
           if (view) {
  -            QRect r = getRectToExpose(viewRect, rect, verticalAlignment, verticalAlignment);
  +            QRect r = getRectToExpose(viewRect, rect, verticalAlignment, horizontalAlignment);
               view->ensureRectVisible(r);
           }
           if (m_object->document() && m_object->document()->ownerElement() && m_object->document()->ownerElement()->renderer()) {