[webkit-changes] cvs commit: WebCore/khtml/css cssstyleselector.cpp

[David]

hyatt       05/10/26 15:13:29

  Modified:    .        ChangeLog
               khtml/css cssstyleselector.cpp
  Log:
  	Don't allow position:relative to apply to table sections.  Fixes the crash described in
  	Radar bug 4107882. (http://cityoflakeforest.com/cs/pw/cs_pw2a3.htm)
  
          Reviewed by bdakin
  
          * khtml/css/cssstyleselector.cpp:
          (khtml::CSSStyleSelector::adjustRenderStyle):
  
  Revision  Changes    Path
  1.297     +10 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.296
  retrieving revision 1.297
  diff -u -r1.296 -r1.297
  --- ChangeLog	26 Oct 2005 21:47:29 -0000	1.296
  +++ ChangeLog	26 Oct 2005 22:13:26 -0000	1.297
  @@ -1,3 +1,13 @@
  +2005-10-26  David Hyatt  <hyatt at apple.com>
  +
  +	Don't allow position:relative to apply to table sections.  Fixes the crash described in
  +	Radar bug 4107882. (http://cityoflakeforest.com/cs/pw/cs_pw2a3.htm)
  +	
  +        Reviewed by bdakin
  +
  +        * khtml/css/cssstyleselector.cpp:
  +        (khtml::CSSStyleSelector::adjustRenderStyle):
  +        
   2005-10-26  Adele Peterson  <adele at apple.com>
   
           Reviewed by John.
  
  
  
  1.216     +3 -1      WebCore/khtml/css/cssstyleselector.cpp
  
  Index: cssstyleselector.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/css/cssstyleselector.cpp,v
  retrieving revision 1.215
  retrieving revision 1.216
  diff -u -r1.215 -r1.216
  --- cssstyleselector.cpp	26 Oct 2005 19:44:04 -0000	1.215
  +++ cssstyleselector.cpp	26 Oct 2005 22:13:29 -0000	1.216
  @@ -955,7 +955,9 @@
           // After performing the display mutation, check table rows.  We do not honor position:relative on
           // table rows or cells.  This has been established in CSS2.1 (and caused a crash in containingBlock()
           // on some sites).
  -        if ((style->display() == TABLE_ROW || style->display() == TABLE_CELL) && style->position() == RELATIVE)
  +        if ((style->display() == TABLE_HEADER_GROUP || style->display() == TABLE_ROW_GROUP ||
  +             style->display() == TABLE_FOOTER_GROUP || style->display() == TABLE_ROW || style->display() == TABLE_CELL) &&
  +             style->position() == RELATIVE)
               style->setPosition(STATIC);
       }