[webkit-changes] cvs commit: WebCore/kwq DOM.mm

[Maciej]

mjs         05/10/25 21:55:09

  Modified:    .        ChangeLog
               khtml/ecma kjs_dom.cpp kjs_dom.h
               khtml/xml dom_nodeimpl.h
               kwq      DOM.mm
  Log:
          Re-landing the isSameNode fix from Anders, I verified there is no effect on performance:
  
  	<rdar://problem/4302880> Re-land isSameNode change
  
          * khtml/ecma/kjs_dom.cpp:
          * khtml/ecma/kjs_dom.h:
          * khtml/xml/dom_nodeimpl.h:
          * kwq/DOM.mm:
  
  Revision  Changes    Path
  1.290     +11 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.289
  retrieving revision 1.290
  diff -u -r1.289 -r1.290
  --- ChangeLog	25 Oct 2005 23:46:21 -0000	1.289
  +++ ChangeLog	26 Oct 2005 04:55:04 -0000	1.290
  @@ -1,5 +1,16 @@
   2005-10-25  Maciej Stachowiak  <mjs at apple.com>
   
  +        Re-landing the isSameNode fix from Anders, I verified there is no effect on performance:
  +
  +	<rdar://problem/4302880> Re-land isSameNode change
  +	
  +        * khtml/ecma/kjs_dom.cpp:
  +        * khtml/ecma/kjs_dom.h:
  +        * khtml/xml/dom_nodeimpl.h:
  +        * kwq/DOM.mm:
  +
  +2005-10-25  Maciej Stachowiak  <mjs at apple.com>
  +
           Re-land the following fix, I tested to verify there is no performance regression:
   
   	Makes <object> tags not use image mode for svg content:
  
  
  
  1.103     +6 -2      WebCore/khtml/ecma/kjs_dom.cpp
  
  Index: kjs_dom.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_dom.cpp,v
  retrieving revision 1.102
  retrieving revision 1.103
  diff -u -r1.102 -r1.103
  --- kjs_dom.cpp	16 Oct 2005 03:36:04 -0000	1.102
  +++ kjs_dom.cpp	26 Oct 2005 04:55:08 -0000	1.103
  @@ -88,7 +88,7 @@
   
   // -------------------------------------------------------------------------
   /* Source for DOMNodeProtoTable. Use "make hashtables" to regenerate.
  - at begin DOMNodeProtoTable 13
  + at begin DOMNodeProtoTable 14
     insertBefore	DOMNode::InsertBefore	DontDelete|Function 2
     replaceChild	DOMNode::ReplaceChild	DontDelete|Function 2
     removeChild	DOMNode::RemoveChild	DontDelete|Function 1
  @@ -99,6 +99,8 @@
   # DOM2
     normalize	DOMNode::Normalize	DontDelete|Function 0
     isSupported   DOMNode::IsSupported	DontDelete|Function 2
  +# DOM3
  +  isSameNode    DOMNode::IsSameNode     DontDelete|Function 1
   # from the EventTarget interface
     addEventListener	DOMNode::AddEventListener	DontDelete|Function 3
     removeEventListener	DOMNode::RemoveEventListener	DontDelete|Function 3
  @@ -190,7 +192,7 @@
   }
   
   /* Source for DOMNodeTable. Use "make hashtables" to regenerate.
  - at begin DOMNodeTable 67
  + at begin DOMNodeTable 68
     nodeName	DOMNode::NodeName	DontDelete|ReadOnly
     nodeValue	DOMNode::NodeValue	DontDelete
     nodeType	DOMNode::NodeType	DontDelete|ReadOnly
  @@ -649,6 +651,8 @@
       case DOMNode::IsSupported:
           return Boolean(node.isSupported(args[0]->toString(exec).domString(),
               args[1]->isUndefinedOrNull() ? DOMString() : args[1]->toString(exec).domString()));
  +    case DOMNode::IsSameNode:
  +        return Boolean(node.isSameNode(toNode(args[0])));
       case DOMNode::AddEventListener: {
           JSEventListener *listener = Window::retrieveActive(exec)->getJSEventListener(args[1]);
           if (listener)
  
  
  
  1.54      +1 -1      WebCore/khtml/ecma/kjs_dom.h
  
  Index: kjs_dom.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_dom.h,v
  retrieving revision 1.53
  retrieving revision 1.54
  diff -u -r1.53 -r1.54
  --- kjs_dom.h	16 Oct 2005 03:36:04 -0000	1.53
  +++ kjs_dom.h	26 Oct 2005 04:55:08 -0000	1.54
  @@ -69,7 +69,7 @@
              Attributes, NamespaceURI, Prefix, LocalName, OwnerDocument, InsertBefore,
              ReplaceChild, RemoveChild, AppendChild, HasAttributes, HasChildNodes,
              CloneNode, Normalize, IsSupported, AddEventListener, RemoveEventListener,
  -           DispatchEvent, Contains,
  +           DispatchEvent, Contains, IsSameNode,
              OnAbort, OnBlur, OnChange, OnClick, OnContextMenu, OnDblClick, OnDragDrop, OnError,
              OnDragEnter, OnDragOver, OnDragLeave, OnDrop, OnDragStart, OnDrag, OnDragEnd,
              OnBeforeCut, OnCut, OnBeforeCopy, OnCopy, OnBeforePaste, OnPaste, OnSelectStart,
  
  
  
  1.108     +2 -0      WebCore/khtml/xml/dom_nodeimpl.h
  
  Index: dom_nodeimpl.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_nodeimpl.h,v
  retrieving revision 1.107
  retrieving revision 1.108
  diff -u -r1.107 -r1.108
  --- dom_nodeimpl.h	25 Oct 2005 00:07:47 -0000	1.107
  +++ dom_nodeimpl.h	26 Oct 2005 04:55:09 -0000	1.108
  @@ -111,6 +111,8 @@
       void normalize ();
       static bool isSupported(const DOMString &feature, const DOMString &version);
   
  +    bool isSameNode(NodeImpl *other) { return this == other; }
  +    
       NodeImpl *lastDescendant() const;
   
       // Other methods (not part of DOM)
  
  
  
  1.53      +5 -0      WebCore/kwq/DOM.mm
  
  Index: DOM.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/DOM.mm,v
  retrieving revision 1.52
  retrieving revision 1.53
  diff -u -r1.52 -r1.53
  --- DOM.mm	16 Oct 2005 03:36:07 -0000	1.52
  +++ DOM.mm	26 Oct 2005 04:55:09 -0000	1.53
  @@ -376,6 +376,11 @@
       return [self _nodeImpl]->hasAttributes();
   }
   
  +- (BOOL)isSameNode:(DOMNode *)other
  +{
  +    return [self _nodeImpl]->isSameNode([other _nodeImpl]);
  +}
  +
   - (void)addEventListener:(NSString *)type :(id <DOMEventListener>)listener :(BOOL)useCapture
   {
       EventListener *wrapper = ObjCEventListener::create(listener);