[webkit-changes] cvs commit: LayoutTests/fast/forms blankbuttons.html blankbuttons-expected.txt

Mon Oct 24 15:43:51 PDT 2005

hyatt       05/10/24 15:43:50

  Modified:    .        ChangeLog
               khtml/rendering render_button.cpp
  Added:       fast/forms blankbuttons.html blankbuttons-expected.txt
  Log:
  	Make sure the button's generated text using the value with
  	the default label so that Submit/Reset buttons aren't blank.
  
          Reviewed by mjs
  
  	Added fast/forms/blankbuttons.html
  
          * khtml/rendering/render_button.cpp:
          (khtml::RenderButton::updateFromElement):
  
  Revision  Changes    Path
  1.276     +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.275
  retrieving revision 1.276
  diff -u -r1.275 -r1.276
  --- ChangeLog	24 Oct 2005 22:33:50 -0000	1.275
  +++ ChangeLog	24 Oct 2005 22:43:45 -0000	1.276
  @@ -1,3 +1,15 @@
  +2005-10-23  David Hyatt  <hyatt at apple.com>
  +
  +	Make sure the button's generated text using the value with
  +	the default label so that Submit/Reset buttons aren't blank.
  +	
  +        Reviewed by mjs
  +
  +	Added fast/forms/blankbuttons.html
  +	
  +        * khtml/rendering/render_button.cpp:
  +        (khtml::RenderButton::updateFromElement):
  +
   2005-10-24  Maciej Stachowiak  <mjs at apple.com>
   
           Re-landing Dave Hyatt's changes from when the tree was closed.
  
  
  
  1.3       +1 -1      WebCore/khtml/rendering/render_button.cpp
  
  Index: render_button.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_button.cpp,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- render_button.cpp	22 Oct 2005 18:19:27 -0000	1.2
  +++ render_button.cpp	24 Oct 2005 22:43:49 -0000	1.3
  @@ -75,7 +75,7 @@
       // If we're an input element, we may need to change our button text.
       if (element()->hasTagName(inputTag)) {
           HTMLInputElementImpl* input = static_cast<HTMLInputElementImpl*>(element());
  -        DOMString value = input->value();
  +        DOMString value = input->valueWithDefault();
           if (value.isEmpty()) {
               if (m_buttonText) {
                   m_buttonText->destroy();
  
  
  
  1.1                  LayoutTests/fast/forms/blankbuttons.html
  
  Index: blankbuttons.html
  ===================================================================
  <html>
  <body>
  <input type=submit><br>
  <input type=reset><br>
  </body>
  </html>
  
  
  
  1.1                  LayoutTests/fast/forms/blankbuttons-expected.txt
  
  Index: blankbuttons-expected.txt
  ===================================================================
  layer at (0,0) size 800x600
    RenderCanvas at (0,0) size 800x600
  layer at (0,0) size 800x600
    RenderBlock {HTML} at (0,0) size 800x600
      RenderBody {BODY} at (8,8) size 784x584
        RenderButton {INPUT} at (2,2) size 54x18
          RenderBlock (anonymous) at (8,2) size 38x13
            RenderText at (0,0) size 38x13
              text run at (0,0) width 38: "Submit"
        RenderBR {BR} at (0,0) size 0x0
        RenderButton {INPUT} at (2,24) size 45x18
          RenderBlock (anonymous) at (8,2) size 29x13
            RenderText at (0,0) size 29x13
              text run at (0,0) width 29: "Reset"
        RenderBR {BR} at (0,0) size 0x0