[webkit-changes] cvs commit: WebKit/WebView.subproj WebDataSource.m

[Geoffrey]

ggaren      05/10/23 18:43:04

  Modified:    .        ChangeLog
               WebView.subproj WebDataSource.m
  Log:
          Reviewed by Maciej.
  
          For better abstraction, made the tokenizer -- instead of the
          data source -- responsible for calling [WebFrame _checkLoadComplete]
          when the tokenizer stops.
  
          * WebView.subproj/WebDataSource.m:
          (-[WebDataSource _stopLoadingInternal]):
  
  Revision  Changes    Path
  1.3359    +11 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3358
  retrieving revision 1.3359
  diff -u -r1.3358 -r1.3359
  --- ChangeLog	22 Oct 2005 01:42:01 -0000	1.3358
  +++ ChangeLog	24 Oct 2005 01:42:57 -0000	1.3359
  @@ -1,3 +1,14 @@
  +2005-10-23  Geoffrey Garen  <ggaren at apple.com>
  +
  +        Reviewed by Maciej.
  +
  +        For better abstraction, made the tokenizer -- instead of the 
  +        data source -- responsible for calling [WebFrame _checkLoadComplete]
  +        when the tokenizer stops.
  +
  +        * WebView.subproj/WebDataSource.m:
  +        (-[WebDataSource _stopLoadingInternal]):
  +
   2005-10-21  Geoffrey Garen  <ggaren at apple.com>
   
           Reviewed by darin.
  
  
  
  1.215     +1 -6      WebKit/WebView.subproj/WebDataSource.m
  
  Index: WebDataSource.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebDataSource.m,v
  retrieving revision 1.214
  retrieving revision 1.215
  diff -u -r1.214 -r1.215
  --- WebDataSource.m	22 Oct 2005 01:42:04 -0000	1.214
  +++ WebDataSource.m	24 Oct 2005 01:43:03 -0000	1.215
  @@ -452,13 +452,8 @@
       [_private->iconLoader stopLoading];
   
       // The same goes for the bridge/part, which may still be parsing.
  -    if (_private->committed) {
  +    if (_private->committed)
           [[self _bridge] stopLoading];
  -      
  -        // If the data source was done loading, but the tokenizer was still running, the frame
  -        // didn't have a chance to fire its didFinish delegates, so we give it a chance here.
  -        [[self webFrame] _checkLoadComplete];
  -    }
   
       if (!_private->loading) {
   	return;