[webkit-changes] cvs commit: WebCore/khtml/rendering bidi.cpp

[Timothy]

thatcher    05/10/13 15:07:53

  Modified:    .        ChangeLog
               khtml/rendering bidi.cpp
  Log:
          Reviewed by Darin.
  
          no need to calculate linewidth multiple times in findnextlinebreak()
          http://bugzilla.opendarwin.org/show_bug.cgi?id=5319
  
          No test case needed, this is a simple optimization.
  
          * khtml/rendering/bidi.cpp:
          (khtml::RenderBlock::findNextLineBreak):
  
  Revision  Changes    Path
  1.240     +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.239
  retrieving revision 1.240
  diff -u -r1.239 -r1.240
  --- ChangeLog	13 Oct 2005 19:11:20 -0000	1.239
  +++ ChangeLog	13 Oct 2005 22:07:46 -0000	1.240
  @@ -1,3 +1,15 @@
  +2005-10-13  Antti Koivisto  <koivisto at iki.fi>
  +
  +        Reviewed by Darin.
  +
  +        no need to calculate linewidth multiple times in findnextlinebreak()
  +        http://bugzilla.opendarwin.org/show_bug.cgi?id=5319
  +
  +        No test case needed, this is a simple optimization.
  +
  +        * khtml/rendering/bidi.cpp:
  +        (khtml::RenderBlock::findNextLineBreak):
  +
   2005-10-13  Geoffrey Garen  <ggaren at apple.com>
   
           - Fixed <rdar://problem/4259434> Safari crashes in HTMLTokenizer::~HTMLTokenizer() 
  
  
  
  1.149     +2 -3      WebCore/khtml/rendering/bidi.cpp
  
  Index: bidi.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/bidi.cpp,v
  retrieving revision 1.148
  retrieving revision 1.149
  diff -u -r1.148 -r1.149
  --- bidi.cpp	10 Oct 2005 07:16:23 -0000	1.148
  +++ bidi.cpp	13 Oct 2005 22:07:51 -0000	1.149
  @@ -1941,7 +1941,8 @@
   
   BidiIterator RenderBlock::findNextLineBreak(BidiIterator &start, BidiState &bidi)
   {
  -    int width = lineWidth(m_height);
  +    // eliminate spaces at beginning of line
  +    int width = skipWhitespace(start, bidi);
       int w = 0;
       int tmpW = 0;
   #ifdef DEBUG_LINEBREAKS
  @@ -1949,8 +1950,6 @@
       kdDebug(6041) << "sol: " << start.obj << " " << start.pos << endl;
   #endif
   
  -    // eliminate spaces at beginning of line
  -    width = skipWhitespace(start, bidi);
       if (start.atEnd())
           return start;