[webkit-changes] cvs commit: SVGSupport/layout-tests/W3C-SVG-1.1 filters-color-01-b-expected.checksum filters-color-01-b-expected.png filters-color-01-b-expected.txt struct-symbol-01-b-expected.checksum struct-symbol-01-b-expected.png struct-symbol-01-b-expected.txt

Eric eseidel at opensource.apple.com
Thu Oct 13 01:29:22 PDT 2005


eseidel     05/10/13 01:29:21

  Modified:    .        ChangeLog
               ksvg2/svg SVGPreserveAspectRatioImpl.cpp
                        SVGSVGElementImpl.cpp
               layout-tests/W3C-SVG-1.1
                        filters-color-01-b-expected.checksum
                        filters-color-01-b-expected.png
                        filters-color-01-b-expected.txt
                        struct-symbol-01-b-expected.checksum
                        struct-symbol-01-b-expected.png
                        struct-symbol-01-b-expected.txt
  Log:
  Bug #: 5326
  Submitted by: Rob Buis  <rwlbuis at xs4all.nl>
  Reviewed by: eseidel
          Test cases updated:
          * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
          * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.png:
          * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
          * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
          * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
          * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  
          Fixed <svg> to base %lengths off of the nearest viewbox.
          http://bugzilla.opendarwin.org/show_bug.cgi?id=5326
  
          * ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
          (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
          * ksvg2/svg/SVGSVGElementImpl.cpp:
          (SVGSVGElementImpl::x):
          (SVGSVGElementImpl::y):
          (SVGSVGElementImpl::width):
          (SVGSVGElementImpl::height):
  
  Revision  Changes    Path
  1.238     +23 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.237
  retrieving revision 1.238
  diff -u -r1.237 -r1.238
  --- ChangeLog	13 Oct 2005 00:49:25 -0000	1.237
  +++ ChangeLog	13 Oct 2005 08:29:19 -0000	1.238
  @@ -1,3 +1,26 @@
  +2005-10-13  Rob Buis  <rwlbuis at xs4all.nl>
  +
  +        Reviewed by eseidel.
  +
  +        Test cases updated:
  +        * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  +        * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.png:
  +        * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  +        * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  +        * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  +        * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  +
  +        Fixed <svg> to base %lengths off of the nearest viewbox.
  +        http://bugzilla.opendarwin.org/show_bug.cgi?id=5326
  +
  +        * ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  +        (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
  +        * ksvg2/svg/SVGSVGElementImpl.cpp:
  +        (SVGSVGElementImpl::x):
  +        (SVGSVGElementImpl::y):
  +        (SVGSVGElementImpl::width):
  +        (SVGSVGElementImpl::height):
  +
   2005-10-12  Vicki Murley  <vicki at apple.com>
   
           Reviewed by Hyatt.
  
  
  
  1.7       +1 -1      SVGSupport/ksvg2/svg/SVGPreserveAspectRatioImpl.cpp
  
  Index: SVGPreserveAspectRatioImpl.cpp
  ===================================================================
  RCS file: /cvs/root/SVGSupport/ksvg2/svg/SVGPreserveAspectRatioImpl.cpp,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- SVGPreserveAspectRatioImpl.cpp	5 Oct 2005 05:35:27 -0000	1.6
  +++ SVGPreserveAspectRatioImpl.cpp	13 Oct 2005 08:29:20 -0000	1.7
  @@ -37,7 +37,7 @@
   {
       m_context = context;
       m_meetOrSlice = SVG_MEETORSLICE_MEET;
  -    m_align = SVG_PRESERVEASPECTRATIO_XMINYMID;
  +    m_align = SVG_PRESERVEASPECTRATIO_XMIDYMID;
   }
   
   SVGPreserveAspectRatioImpl::~SVGPreserveAspectRatioImpl()
  
  
  
  1.9       +4 -4      SVGSupport/ksvg2/svg/SVGSVGElementImpl.cpp
  
  Index: SVGSVGElementImpl.cpp
  ===================================================================
  RCS file: /cvs/root/SVGSupport/ksvg2/svg/SVGSVGElementImpl.cpp,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- SVGSVGElementImpl.cpp	5 Oct 2005 05:35:28 -0000	1.8
  +++ SVGSVGElementImpl.cpp	13 Oct 2005 08:29:20 -0000	1.9
  @@ -87,12 +87,12 @@
   
   SVGAnimatedLengthImpl *SVGSVGElementImpl::x() const
   {
  -    return lazy_create<SVGAnimatedLengthImpl>(m_x, static_cast<const SVGStyledElementImpl *>(0), LM_WIDTH, this);
  +    return lazy_create<SVGAnimatedLengthImpl>(m_x, static_cast<const SVGStyledElementImpl *>(0), LM_WIDTH, ownerDocument()->documentElement() == static_cast<const KDOM::ElementImpl *>(this) ? this : viewportElement());
   }
   
   SVGAnimatedLengthImpl *SVGSVGElementImpl::y() const
   {
  -    return lazy_create<SVGAnimatedLengthImpl>(m_y, static_cast<const SVGStyledElementImpl *>(0), LM_HEIGHT, this);
  +    return lazy_create<SVGAnimatedLengthImpl>(m_y, static_cast<const SVGStyledElementImpl *>(0), LM_HEIGHT, ownerDocument()->documentElement() == static_cast<const KDOM::ElementImpl *>(this) ? this : viewportElement());
   }
   
   SVGAnimatedLengthImpl *SVGSVGElementImpl::width() const
  @@ -100,7 +100,7 @@
       if(!m_width)
       {
           KDOM::DOMString temp("100%");
  -        lazy_create<SVGAnimatedLengthImpl>(m_width, static_cast<const SVGStyledElementImpl *>(0), LM_WIDTH, this);
  +        lazy_create<SVGAnimatedLengthImpl>(m_width, static_cast<const SVGStyledElementImpl *>(0), LM_WIDTH, ownerDocument()->documentElement() == static_cast<const KDOM::ElementImpl *>(this) ? this : viewportElement());
           m_width->baseVal()->setValueAsString(temp.handle());
       }
   
  @@ -112,7 +112,7 @@
       if(!m_height)
       {
           KDOM::DOMString temp("100%");
  -        lazy_create<SVGAnimatedLengthImpl>(m_height, static_cast<const SVGStyledElementImpl *>(0), LM_HEIGHT, this);
  +        lazy_create<SVGAnimatedLengthImpl>(m_height, static_cast<const SVGStyledElementImpl *>(0), LM_HEIGHT, ownerDocument()->documentElement() == static_cast<const KDOM::ElementImpl *>(this) ? this : viewportElement());
           m_height->baseVal()->setValueAsString(temp.handle());
       }
   
  
  
  
  1.2       +1 -1      SVGSupport/layout-tests/W3C-SVG-1.1/filters-color-01-b-expected.checksum
  
  Index: filters-color-01-b-expected.checksum
  ===================================================================
  RCS file: /cvs/root/SVGSupport/layout-tests/W3C-SVG-1.1/filters-color-01-b-expected.checksum,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- filters-color-01-b-expected.checksum	18 Aug 2005 08:31:38 -0000	1.1
  +++ filters-color-01-b-expected.checksum	13 Oct 2005 08:29:21 -0000	1.2
  @@ -1 +1 @@
  -0fed2ac026fbcd5e0da6d34b0857c3e6
  \ No newline at end of file
  +42f1c3af5e2a656e86e3de8c1cf7ad6b
  \ No newline at end of file
  
  
  
  1.2       +13 -12    SVGSupport/layout-tests/W3C-SVG-1.1/filters-color-01-b-expected.png
  
  	<<Binary file>>
  
  
  1.4       +10 -10    SVGSupport/layout-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt
  
  Index: filters-color-01-b-expected.txt
  ===================================================================
  RCS file: /cvs/root/SVGSupport/layout-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- filters-color-01-b-expected.txt	6 Sep 2005 10:18:04 -0000	1.3
  +++ filters-color-01-b-expected.txt	13 Oct 2005 08:29:21 -0000	1.4
  @@ -4,14 +4,14 @@
     KCanvasResource {id="Saturate40" [type=FILTER]  [bounding box=at (-5,-5) size 110x110] [effect bounding box mode=0] [effects=[[type=COLOR-MATRIX] [in="SourceGraphic"] [color matrix type=CMT_SATURATE] [values=[0.25]]]]}
     KCanvasResource {id="LuminanceToAlpha" [type=FILTER]  [bounding box=at (-5,-5) size 110x110] [effect bounding box mode=0] [effects=[[type=COLOR-MATRIX] [in="SourceGraphic"] [result="a"] [color matrix type=LUMINANCE-TO-ALPHA] [values=[]], [type=COMPOSITE] [in="SourceGraphic"] [in2="a"] [k1=0.00 k2=0.00 k3=0.00 k4=0.00]]]}
     KRenderingPaintServer {id="MyGradient" [type=LINEAR-GRADIENT] [stops=[(0.00,#DD00DD), (0.33,#22CC22), (0.67,#400000), (1.00,#A0A0FF)]] [start=(0,0)] [end=(0,0)]}
  -KCanvasContainer at (-9,0) size 488x359
  -  KCanvasContainer at (-9,5) size 463x289 [fill={[type=SOLID] [color=#000000]}]
  -    KCanvasContainer at (-9,5) size 463x289 [transform={m=((0.58,0.00)(0.00,0.58)) t=(-10.00,5.00)}]
  -      KCanvasContainer at (-9,5) size 463x289 [fill={[type=SOLID] [color=#000000]}]
  -        KCanvasItem {rect} at (-9,5) size 463x289 [stroke={[type=SOLID] [color=#0000FF]}] [data="M1.00,1.00L799.00,1.00L799.00,499.00L1.00,499.00"]
  -        KCanvasItem {rect} at (1,16) size 440x23 [fill={[id="MyGradient"]}] [data="M20.00,20.00L780.00,20.00L780.00,60.00L20.00,60.00"]
  -        KCanvasItem {rect} at (1,74) size 440x23 [fill={[id="MyGradient"]}] [filter="Matrix"] [data="M20.00,120.00L780.00,120.00L780.00,160.00L20.00,160.00"]
  -        KCanvasItem {rect} at (1,132) size 440x23 [fill={[id="MyGradient"]}] [filter="Saturate40"] [data="M20.00,220.00L780.00,220.00L780.00,260.00L20.00,260.00"]
  -        KCanvasItem {rect} at (1,190) size 440x23 [fill={[id="MyGradient"]}] [filter="HueRotate90"] [data="M20.00,320.00L780.00,320.00L780.00,360.00L20.00,360.00"]
  -        KCanvasItem {rect} at (1,248) size 440x23 [fill={[id="MyGradient"]}] [filter="LuminanceToAlpha"] [data="M20.00,420.00L780.00,420.00L780.00,460.00L20.00,460.00"]
  +KCanvasContainer at (0,0) size 479x359
  +  KCanvasContainer at (8,5) size 463x289 [fill={[type=SOLID] [color=#000000]}]
  +    KCanvasContainer at (8,5) size 463x289 [transform={m=((0.58,0.00)(0.00,0.58)) t=(8.00,5.00)}]
  +      KCanvasContainer at (8,5) size 463x289 [fill={[type=SOLID] [color=#000000]}]
  +        KCanvasItem {rect} at (8,5) size 463x289 [stroke={[type=SOLID] [color=#0000FF]}] [data="M1.00,1.00L799.00,1.00L799.00,499.00L1.00,499.00"]
  +        KCanvasItem {rect} at (19,16) size 440x23 [fill={[id="MyGradient"]}] [data="M20.00,20.00L780.00,20.00L780.00,60.00L20.00,60.00"]
  +        KCanvasItem {rect} at (19,74) size 440x23 [fill={[id="MyGradient"]}] [filter="Matrix"] [data="M20.00,120.00L780.00,120.00L780.00,160.00L20.00,160.00"]
  +        KCanvasItem {rect} at (19,132) size 440x23 [fill={[id="MyGradient"]}] [filter="Saturate40"] [data="M20.00,220.00L780.00,220.00L780.00,260.00L20.00,260.00"]
  +        KCanvasItem {rect} at (19,190) size 440x23 [fill={[id="MyGradient"]}] [filter="HueRotate90"] [data="M20.00,320.00L780.00,320.00L780.00,360.00L20.00,360.00"]
  +        KCanvasItem {rect} at (19,248) size 440x23 [fill={[id="MyGradient"]}] [filter="LuminanceToAlpha"] [data="M20.00,420.00L780.00,420.00L780.00,460.00L20.00,460.00"]
     KCanvasItem {rect} at (0,0) size 479x359 [stroke={[type=SOLID] [color=#000000]}] [data="M1.00,1.00L479.00,1.00L479.00,359.00L1.00,359.00"]
  
  
  
  1.2       +1 -1      SVGSupport/layout-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum
  
  Index: struct-symbol-01-b-expected.checksum
  ===================================================================
  RCS file: /cvs/root/SVGSupport/layout-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- struct-symbol-01-b-expected.checksum	18 Aug 2005 08:31:57 -0000	1.1
  +++ struct-symbol-01-b-expected.checksum	13 Oct 2005 08:29:21 -0000	1.2
  @@ -1 +1 @@
  -30436c8a6010788fde414e1211cd933b
  \ No newline at end of file
  +a4ce5c507449ccbed31fc0bf3497bc53
  \ No newline at end of file
  
  
  
  1.2       +1 -1      SVGSupport/layout-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.png
  
  	<<Binary file>>
  
  
  1.4       +13 -13    SVGSupport/layout-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt
  
  Index: struct-symbol-01-b-expected.txt
  ===================================================================
  RCS file: /cvs/root/SVGSupport/layout-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- struct-symbol-01-b-expected.txt	6 Sep 2005 10:18:14 -0000	1.3
  +++ struct-symbol-01-b-expected.txt	13 Oct 2005 08:29:21 -0000	1.4
  @@ -1,16 +1,16 @@
   KCanvasRegistry: empty
   KCanvasContainer at (0,0) size 479x359
  -  KCanvasContainer at (0,0) size 390x300 [fill={[type=SOLID] [color=#000000]}]
  -    KCanvasContainer at (0,0) size 390x300 [fill={[type=SOLID] [color=#000000]}]
  -      KCanvasContainer at (0,0) size 150x150 [fill={[type=SOLID] [color=#000000]}]
  -        KCanvasContainer at (0,0) size 150x150 [fill={[type=SOLID] [color=#000000]}]
  -          KCanvasContainer at (0,0) size 150x150 [transform={m=((0.15,0.00)(0.00,0.15)) t=(0.00,0.00)}]
  -            KCanvasItem at (0,0) size 150x150 [fill={[type=IMAGE]}] [data="M0.00,0.00L1000.00,0.00L1000.00,1000.00L0.00,1000.00"]
  -      KCanvasContainer at (240,150) size 150x150 [fill={[type=SOLID] [color=#000000]}]
  -        KCanvasContainer at (240,150) size 150x150 [transform={m=((1.00,0.00)(0.00,1.00)) t=(240.00,150.00)}] [fill={[type=SOLID] [color=#000000]}]
  -          KCanvasContainer at (240,150) size 150x150 [transform={m=((0.15,0.00)(0.00,0.15)) t=(240.00,150.00)}]
  -            KCanvasItem {rect} at (240,150) size 75x75 [fill={[type=SOLID] [color=#FFFF00]}] [data="M0.00,0.00L500.00,0.00L500.00,500.00L0.00,500.00"]
  -            KCanvasItem {rect} at (315,150) size 75x75 [fill={[type=SOLID] [color=#FF0000]}] [data="M500.00,0.00L1000.00,0.00L1000.00,500.00L500.00,500.00"]
  -            KCanvasItem {rect} at (240,225) size 75x75 [fill={[type=SOLID] [color=#FF0000]}] [data="M0.00,500.00L500.00,500.00L500.00,1000.00L0.00,1000.00"]
  -            KCanvasItem {rect} at (315,225) size 75x75 [fill={[type=SOLID] [color=#FFFF00]}] [data="M500.00,500.00L1000.00,500.00L1000.00,1000.00L500.00,1000.00"]
  +  KCanvasContainer at (45,0) size 390x300 [fill={[type=SOLID] [color=#000000]}]
  +    KCanvasContainer at (45,0) size 390x300 [fill={[type=SOLID] [color=#000000]}]
  +      KCanvasContainer at (45,0) size 150x150 [fill={[type=SOLID] [color=#000000]}]
  +        KCanvasContainer at (45,0) size 150x150 [fill={[type=SOLID] [color=#000000]}]
  +          KCanvasContainer at (45,0) size 150x150 [transform={m=((0.15,0.00)(0.00,0.15)) t=(45.00,0.00)}]
  +            KCanvasItem at (45,0) size 150x150 [fill={[type=IMAGE]}] [data="M0.00,0.00L1000.00,0.00L1000.00,1000.00L0.00,1000.00"]
  +      KCanvasContainer at (285,150) size 150x150 [fill={[type=SOLID] [color=#000000]}]
  +        KCanvasContainer at (285,150) size 150x150 [transform={m=((1.00,0.00)(0.00,1.00)) t=(240.00,150.00)}] [fill={[type=SOLID] [color=#000000]}]
  +          KCanvasContainer at (285,150) size 150x150 [transform={m=((0.15,0.00)(0.00,0.15)) t=(285.00,150.00)}]
  +            KCanvasItem {rect} at (285,150) size 75x75 [fill={[type=SOLID] [color=#FFFF00]}] [data="M0.00,0.00L500.00,0.00L500.00,500.00L0.00,500.00"]
  +            KCanvasItem {rect} at (360,150) size 75x75 [fill={[type=SOLID] [color=#FF0000]}] [data="M500.00,0.00L1000.00,0.00L1000.00,500.00L500.00,500.00"]
  +            KCanvasItem {rect} at (285,225) size 75x75 [fill={[type=SOLID] [color=#FF0000]}] [data="M0.00,500.00L500.00,500.00L500.00,1000.00L0.00,1000.00"]
  +            KCanvasItem {rect} at (360,225) size 75x75 [fill={[type=SOLID] [color=#FFFF00]}] [data="M500.00,500.00L1000.00,500.00L1000.00,1000.00L500.00,1000.00"]
     KCanvasItem {rect} at (0,0) size 479x359 [stroke={[type=SOLID] [color=#000000]}] [data="M1.00,1.00L479.00,1.00L479.00,359.00L1.00,359.00"]
  
  
  



More information about the webkit-changes mailing list