[webkit-changes] cvs commit: WebCore/khtml/ecma kjs_window.cpp

[Geoffrey]

ggaren      05/10/10 23:55:30

  Modified:    .        ChangeLog
               khtml/ecma kjs_window.cpp
  Log:
          - Fixed <rdar://problem/4245682> Regression: CrashTracer: 923 crashes
            in Safari at com.apple.WebCore: KJS::Window::clear + 132
  
          Reviewed by mjs.
  
          No test case because this crash isn't reliably reproducible.
  
          * khtml/ecma/kjs_window.cpp:
          (KJS::Window::Window): Initialize m_returnValueSlot to 0, so that we
          know not to write to it until it's explicitly set to a valid address.
  
  Revision  Changes    Path
  1.229     +13 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.228
  retrieving revision 1.229
  diff -u -r1.228 -r1.229
  --- ChangeLog	11 Oct 2005 02:49:30 -0000	1.228
  +++ ChangeLog	11 Oct 2005 06:55:25 -0000	1.229
  @@ -1,3 +1,16 @@
  +2005-10-10  Geoffrey Garen  <ggaren at apple.com>
  +
  +        - Fixed <rdar://problem/4245682> Regression: CrashTracer: 923 crashes 
  +          in Safari at com.apple.WebCore: KJS::Window::clear + 132
  +
  +        Reviewed by mjs.
  +
  +        No test case because this crash isn't reliably reproducible.
  +
  +        * khtml/ecma/kjs_window.cpp:
  +        (KJS::Window::Window): Initialize m_returnValueSlot to 0, so that we
  +        know not to write to it until it's explicitly set to a valid address.
  +
   2005-10-10  Darin Adler  <darin at apple.com>
   
           Reviewed by Maciej.
  
  
  
  1.183     +1 -0      WebCore/khtml/ecma/kjs_window.cpp
  
  Index: kjs_window.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_window.cpp,v
  retrieving revision 1.182
  retrieving revision 1.183
  diff -u -r1.182 -r1.183
  --- kjs_window.cpp	3 Oct 2005 21:12:14 -0000	1.182
  +++ kjs_window.cpp	11 Oct 2005 06:55:29 -0000	1.183
  @@ -335,6 +335,7 @@
     , m_statusbar(0)
     , m_toolbar(0)
     , m_evt(0)
  +  , m_returnValueSlot(0)
   {
     winq = new WindowQObject(this);
     //kdDebug(6070) << "Window::Window this=" << this << " part=" << m_part << " " << m_part->name() << endl;