[webkit-changes] cvs commit: WebKitTools/Scripts check-dom-results cvs-apply cvs-unapply run-webkit-tests

Darin darin at opensource.apple.com
Sun Oct 9 23:35:13 PDT 2005


darin       05/10/09 23:35:13

  Modified:    .        ChangeLog
               Scripts  check-dom-results cvs-apply cvs-unapply
                        run-webkit-tests
  Log:
          * Scripts/check-dom-results: Dump ".xhtml" for tests in the xhtml directory.
          * Scripts/cvs-apply: Handle added/deleted files in the current directory.
          * Scripts/cvs-unapply: Ditto.
          * Scripts/run-webkit-tests: Add a few more false-positive leaks.
  
  Revision  Changes    Path
  1.114     +7 -0      WebKitTools/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKitTools/ChangeLog,v
  retrieving revision 1.113
  retrieving revision 1.114
  diff -u -r1.113 -r1.114
  --- ChangeLog	9 Oct 2005 02:57:20 -0000	1.113
  +++ ChangeLog	10 Oct 2005 06:35:11 -0000	1.114
  @@ -1,3 +1,10 @@
  +2005-10-09  Darin Adler  <darin at apple.com>
  +
  +        * Scripts/check-dom-results: Dump ".xhtml" for tests in the xhtml directory.
  +        * Scripts/cvs-apply: Handle added/deleted files in the current directory.
  +        * Scripts/cvs-unapply: Ditto.
  +        * Scripts/run-webkit-tests: Add a few more false-positive leaks.
  +
   2005-10-08  Alexey Proskuryakov  <ap at nypop.com>
   
           Reviewed, rearranged and landed by Darin.
  
  
  
  1.6       +3 -1      WebKitTools/Scripts/check-dom-results
  
  Index: check-dom-results
  ===================================================================
  RCS file: /cvs/root/WebKitTools/Scripts/check-dom-results,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- check-dom-results	30 Sep 2005 21:44:42 -0000	1.5
  +++ check-dom-results	10 Oct 2005 06:35:12 -0000	1.6
  @@ -113,8 +113,10 @@
   	    print "    Failed:\n";
   	    
   	    foreach my $failure (sort @failures) {
  +                $directory =~ m|^dom/(\w+)|;
  +                my $extension = $1;
   		$failure =~ s|.*/||;
  -		$failure =~ s|-expected\.txt|.html|;
  +		$failure =~ s|-expected\.txt|.${extension}|;
   		print "        ${directory}/${failure}";
   	    }
   	}
  
  
  
  1.8       +4 -2      WebKitTools/Scripts/cvs-apply
  
  Index: cvs-apply
  ===================================================================
  RCS file: /cvs/root/WebKitTools/Scripts/cvs-apply,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- cvs-apply	6 Oct 2005 15:44:59 -0000	1.7
  +++ cvs-apply	10 Oct 2005 06:35:12 -0000	1.8
  @@ -111,10 +111,12 @@
           # Either a deletion or an addition.
   
           # Change directory down into the directory in question.
  -        $patch =~ m|^Index: (([^/\n]*/)+)([^/\n]+)| or die;
  +        $patch =~ m|^Index: (([^/\n]*/)*)([^/\n]+)| or die;
           my $prefix = $1;
           my $base = $3;
  -        chdir $prefix if $prefix;
  +        if ($prefix) {
  +            chdir $prefix or die;
  +        }
   
           if ($patch =~ /\n@@ .* \+0,0 @@/) {
               # Deletion.
  
  
  
  1.6       +6 -5      WebKitTools/Scripts/cvs-unapply
  
  Index: cvs-unapply
  ===================================================================
  RCS file: /cvs/root/WebKitTools/Scripts/cvs-unapply,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- cvs-unapply	19 Aug 2005 16:09:58 -0000	1.5
  +++ cvs-unapply	10 Oct 2005 06:35:12 -0000	1.6
  @@ -83,12 +83,13 @@
       } else {
           # Either a deletion or an addition.
   
  -        $patch =~ m|^Index: (([^/\n]*/)+)([^/\n]+)| or die;
  -        my $prefix = $1 || ".";
  -        my $base = $3;
  -
           # Change directory down into the directory in question.
  -        chdir $prefix or die;
  +        $patch =~ m|^Index: (([^/\n]*/)*)([^/\n]+)| or die;
  +        my $prefix = $1;
  +        my $base = $3;
  +        if ($prefix) {
  +            chdir $prefix or die;
  +        }
   
           if ($patch =~ /\n@@ .* \+0,0 @@/) {
               # Reverse a deletion.
  
  
  
  1.31      +13 -6     WebKitTools/Scripts/run-webkit-tests
  
  Index: run-webkit-tests
  ===================================================================
  RCS file: /cvs/root/WebKitTools/Scripts/run-webkit-tests,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- run-webkit-tests	30 Sep 2005 21:44:42 -0000	1.30
  +++ run-webkit-tests	10 Oct 2005 06:35:12 -0000	1.31
  @@ -524,15 +524,22 @@
       $atLineStart = 1;
   
       # We are excluding the following reported leaks so they don't get in our way when looking for WebKit leaks:
  -    #
  -    #     pthread_create: false positive leak of 'THRD', Radar 3387783
  -    #     _CFPreferencesDomainDeepCopyDictionary: leak apparently in CFPreferences, Radar 4220786
  -    #
  +
  +    my @exclude = (
  +        "pthread_create", # false positive leak of 'THRD', Radar 3387783
  +        "_CFPreferencesDomainDeepCopyDictionary", # leak apparently in CFPreferences, Radar 4220786
  +        "+[NSLanguage initialize]", # leak apparently in NSLanguage, Radar 3986177
  +        "FOGetCoveredUnicodeChars", # leak apparently in ATS, Radar 3943604
  +        "PCFragPrepareClosureFromFile" # leak in Code Fragment Manager, Radar 3426998
  +    );
  +
       # Note that this exclusion doesn't quite work right; sometimes a leak of 'THRD' with no stack trace will
       # still appear in the leaks output.
   
  +    my $excludes = "-exclude '" . (join "' -exclude '", @exclude) . "'";
  +
       print " ? checking for leaks in $toolName\n";
  -    my $leaksOutput = `leaks -exclude pthread_create -exclude _CFPreferencesDomainDeepCopyDictionary $toolPID`;
  +    my $leaksOutput = `leaks $excludes $toolPID`;
       my ($count, $bytes) = $leaksOutput =~ /Process $toolPID: (\d+) leaks? for (\d+) total/;
       my ($excluded) = $leaksOutput =~ /(\d+) leaks? excluded/;
   
  @@ -575,7 +582,7 @@
   }
   
   # Sort numeric parts of strings as numbers, other parts as strings.
  -# Makes 1.33 come before 1.3, which is cool.
  +# Makes 1.33 come after 1.3, which is cool.
   sub numericcmp($$)
   {
       my ($aa, $bb) = @_;
  
  
  



More information about the webkit-changes mailing list