[webkit-changes] cvs commit: WebCore/khtml/html htmlparser.cpp

[Vicki]

vicki       05/10/06 17:46:49

  Modified:    .        ChangeLog
               khtml/html htmlparser.cpp
  Log:
          Reviewed by Beth Dakin.
  
  	- fix <rdar://problem/4288307> <form> element is created for <isindex> outside <form>; that's not correct (4828)
  
          * khtml/html/htmlparser.cpp:
          (HTMLParser::handleIsindex): if there's no current form, don't create one
  
  Revision  Changes    Path
  1.214     +9 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.213
  retrieving revision 1.214
  diff -u -r1.213 -r1.214
  --- ChangeLog	6 Oct 2005 22:45:42 -0000	1.213
  +++ ChangeLog	7 Oct 2005 00:46:45 -0000	1.214
  @@ -1,3 +1,12 @@
  +2005-10-06  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Beth Dakin.
  + 
  +	- fix <rdar://problem/4288307> <form> element is created for <isindex> outside <form>; that's not correct (4828)
  +
  +        * khtml/html/htmlparser.cpp:
  +        (HTMLParser::handleIsindex): if there's no current form, don't create one
  +
   2005-10-06  Beth Dakin  <bdakin at apple.com>
   
           Reviewed by Vicki.
  
  
  
  1.118     +2 -8      WebCore/khtml/html/htmlparser.cpp
  
  Index: htmlparser.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/htmlparser.cpp,v
  retrieving revision 1.117
  retrieving revision 1.118
  diff -u -r1.117 -r1.118
  --- htmlparser.cpp	6 Oct 2005 06:31:35 -0000	1.117
  +++ htmlparser.cpp	7 Oct 2005 00:46:49 -0000	1.118
  @@ -1325,18 +1325,12 @@
   
   NodeImpl *HTMLParser::handleIsindex( Token *t )
   {
  -    NodeImpl *n;
  -    HTMLFormElementImpl *myform = form;
  -    if (!myform) {
  -        myform = new HTMLFormElementImpl(document);
  -        n = myform;
  -    } else
  -        n = new HTMLDivElementImpl(document);
  +    NodeImpl *n = new HTMLDivElementImpl(document);
   
       NamedMappedAttrMapImpl *attrs = t->attrs;
       t->attrs = NULL;
   
  -    HTMLIsIndexElementImpl *isIndex = new HTMLIsIndexElementImpl(document, myform);
  +    HTMLIsIndexElementImpl *isIndex = new HTMLIsIndexElementImpl(document);
       isIndex->setAttributeMap(attrs);
       isIndex->setAttribute(typeAttr, "khtml_isindex");