[webkit-changes] cvs commit: WebCore/khtml/rendering render_container.cpp

[Beth]

bdakin      05/10/06 12:16:14

  Modified:    .        ChangeLog
               khtml/rendering render_container.cpp
  Log:
  Bug #:
  
  Revision  Changes    Path
  1.209     +15 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.208
  retrieving revision 1.209
  diff -u -r1.208 -r1.209
  --- ChangeLog	6 Oct 2005 18:37:38 -0000	1.208
  +++ ChangeLog	6 Oct 2005 19:16:12 -0000	1.209
  @@ -1,3 +1,18 @@
  +2005-10-06  Beth Dakin  <bdakin at apple.com>
  +
  +        Reviewed by Hyatt
  +
  +        No test case added because you need to interact with a page to see this crash. 
  +
  +	Fix for <rdar://problem/3918278> CSS: :hover:before or :hover crashes in 
  +	RenderObject::repaintObjectsBeforeLayout()
  +
  +        * khtml/rendering/render_container.cpp:
  +        (RenderContainer::updatePseudoChild): Deleted call to removeChild() because destroy() takes
  +						care of that, and we don't want to remove the
  +						node before we destroy it anyway, or positioned
  +						objects won't be appropriately deleted. 
  +
   2005-10-06  David Harrison  <harrison at apple.com>
   
           Reviewed by hyatt.
  
  
  
  1.71      +0 -1      WebCore/khtml/rendering/render_container.cpp
  
  Index: render_container.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_container.cpp,v
  retrieving revision 1.70
  retrieving revision 1.71
  diff -u -r1.70 -r1.71
  --- render_container.cpp	6 Oct 2005 00:53:56 -0000	1.70
  +++ render_container.cpp	6 Oct 2005 19:16:13 -0000	1.71
  @@ -243,7 +243,6 @@
           // Nuke the child. 
           if (child && child->style()->styleType() == type) {
               oldContentPresent = false;
  -            removeChild(child);
               child->destroy();
               child = (type == RenderStyle::BEFORE) ? firstChild() : lastChild();
           }