[webkit-changes] cvs commit: WebCore/khtml/html htmlparser.cpp

[Vicki]

vicki       05/10/05 23:31:36

  Modified:    .        ChangeLog
               khtml/html htmlparser.cpp
  Log:
          Reviewed by Maciej.
  
  	- fix <rdar://problem/4288829> repro crash on isIndex tag with no attributes
  
          * khtml/html/htmlparser.cpp:
          (HTMLParser::handleIsindex): only deref attributes if they exist
  
  Revision  Changes    Path
  1.206     +9 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.205
  retrieving revision 1.206
  diff -u -r1.205 -r1.206
  --- ChangeLog	6 Oct 2005 04:13:10 -0000	1.205
  +++ ChangeLog	6 Oct 2005 06:31:34 -0000	1.206
  @@ -1,3 +1,12 @@
  +2005-10-05  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Maciej.
  + 
  +	- fix <rdar://problem/4288829> repro crash on isIndex tag with no attributes
  +
  +        * khtml/html/htmlparser.cpp:
  +        (HTMLParser::handleIsindex): only deref attributes if they exist
  +
   2005-10-05  Maciej Stachowiak  <mjs at apple.com>
   
           Reviewed by Eric.
  
  
  
  1.117     +3 -3      WebCore/khtml/html/htmlparser.cpp
  
  Index: htmlparser.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/htmlparser.cpp,v
  retrieving revision 1.116
  retrieving revision 1.117
  diff -u -r1.116 -r1.117
  --- htmlparser.cpp	5 Oct 2005 07:14:06 -0000	1.116
  +++ htmlparser.cpp	6 Oct 2005 06:31:35 -0000	1.117
  @@ -1345,11 +1345,11 @@
   #else
       DOMString text = i18n("This is a searchable index. Enter search keywords: ");
   #endif
  -    if (attrs)
  +    if (attrs) {
           if (AttributeImpl *a = attrs->getAttributeItem(promptAttr))
               text = a->value().domString() + " ";
  -
  -    attrs->deref();
  +        attrs->deref();
  +    }
   
       n->addChild(new HTMLHRElementImpl(document));
       n->addChild(new TextImpl(document, text));