[webkit-changes] cvs commit: WebCore/khtml/ecma kjs_events.cpp

Maciej mjs at opensource.apple.com
Wed Oct 5 00:01:49 PDT 2005


mjs         05/10/05 00:01:49

  Modified:    .        ChangeLog
               khtml/ecma kjs_events.cpp
  Log:
          Reviewed by Eric.
  
  	<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com
  
  	I couldn't figure out how to make a reproducible test case for this. The failure is
  	random memory trashing.
  
          * khtml/ecma/kjs_events.cpp:
          (KJS::JSAbstractEventListener::handleEvent):
  
  Revision  Changes    Path
  1.197     +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.196
  retrieving revision 1.197
  diff -u -r1.196 -r1.197
  --- ChangeLog	5 Oct 2005 06:08:05 -0000	1.196
  +++ ChangeLog	5 Oct 2005 07:01:47 -0000	1.197
  @@ -1,3 +1,15 @@
  +2005-10-04  Maciej Stachowiak  <mjs at apple.com>
  +
  +        Reviewed by Eric.
  +
  +	<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com
  +	
  +	I couldn't figure out how to make a reproducible test case for this. The failure is
  +	random memory trashing.
  +
  +        * khtml/ecma/kjs_events.cpp:
  +        (KJS::JSAbstractEventListener::handleEvent):
  +
   2005-10-04  Eric Seidel  <eseidel at apple.com>
   
           Reviewed by mjs.
  
  
  
  1.65      +3 -4      WebCore/khtml/ecma/kjs_events.cpp
  
  Index: kjs_events.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_events.cpp,v
  retrieving revision 1.64
  retrieving revision 1.65
  diff -u -r1.64 -r1.65
  --- kjs_events.cpp	3 Oct 2005 21:34:46 -0000	1.64
  +++ kjs_events.cpp	5 Oct 2005 07:01:49 -0000	1.65
  @@ -156,11 +156,10 @@
           if (ret.type() == QVariant::Bool && ret.toBool() == false)
               evt->preventDefault();
         }
  -  }
  -  
  -  DOM::DocumentImpl::updateDocumentsRendering();
     
  -  deref();
  +      DOM::DocumentImpl::updateDocumentsRendering();
  +      deref();
  +  }
   }
   
   DOM::DOMString JSAbstractEventListener::eventListenerType()
  
  
  



More information about the webkit-changes mailing list