[webkit-changes] cvs commit: WebKit/WebCoreSupport.subproj
WebImageData.m
Beth
bdakin at opensource.apple.com
Tue Oct 4 13:24:00 PDT 2005
bdakin 05/10/04 13:24:00
Modified: . ChangeLog
. ChangeLog
WebCoreSupport.subproj WebImageData.m
Added: fast/css button_center.png imageTileOpacity-expected.txt
imageTileOpacity.html
Log:
Revision Changes Path
1.7 +13 -0 LayoutTests/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/LayoutTests/ChangeLog,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- ChangeLog 4 Oct 2005 06:14:37 -0000 1.6
+++ ChangeLog 4 Oct 2005 20:23:52 -0000 1.7
@@ -1,3 +1,16 @@
+2005-10-04 Beth Dakin <bdakin at apple.com>
+
+ Reviewed by Darin.
+
+ Test case for setting opacity on tiled images. Specifically for fix to:
+ <rdar://problem/4285538> TOT fix for Denver Regression: Drawing glitch in
+ the transparent dialog's cancel/ok button in the widget manager. The fix
+ is in WebKit and WebKitSystemInterface.
+
+ * fast/css/button_center.png: Added.
+ * fast/css/imageTileOpacity-expected.txt: Added.
+ * fast/css/imageTileOpacity.html: Added.
+
2005-10-03 Eric Seidel <eseidel at apple.com>
Reviewed by mjs.
1.1 LayoutTests/fast/css/button_center.png
<<Binary file>>
1.1 LayoutTests/fast/css/imageTileOpacity-expected.txt
Index: imageTileOpacity-expected.txt
===================================================================
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
layer at (7,75) size 284x212
RenderBlock (positioned) {DIV} at (7,75) size 284x212 [bgcolor=#000000D1]
layer at (101,237) size 40x24
RenderBlock (positioned) {DIV} at (94,162) size 40x24 [color=#FFFFFF]
RenderBlock {DIV} at (0,0) size 40x24
RenderText {TEXT} at (0,4) size 40x24
text run at (0,4) width 40: "Cancel"
1.1 LayoutTests/fast/css/imageTileOpacity.html
Index: imageTileOpacity.html
===================================================================
<head>
<style type="text/css" title="AppleStyle">
.dialog-background {
position:absolute;
top:75px;
left:7px;
background-color:rgba(0,0,0,0.82);
width:284px;
height:212px;
}
.dialog-cancel-button {
position:absolute;
top:162px;
right:150px;
}
.dialog-button {
font: 12px "Helvetica Neue";
font-weight:bold;
color: white;
opacity:0.5;
}
</style>
<script>
var dialog = null;
function load ()
{
dialog = new Dialog ();
}
function Dialog ()
{
var div = document.createElement('div');
div.setAttribute('id', 'dialog-background');
div.setAttribute('class', 'dialog-background');
var button_div = document.createElement('div');
button_div.setAttribute('class', 'dialog-button dialog-cancel-button');
div.appendChild (button_div);
createDialogButton (button_div, 'Cancel', 66);
document.body.appendChild(div);
this.background = div;
}
function createDialogButton (div, title, minwidth)
{
element = document.createElement('div');
element.setAttribute ("style", 'display:inline-block;text-align:center;line-height:24px;background:url(button_center.png) repeat-x top left;');
div.appendChild (element);
element.innerHTML = title;
}
</script>
</head>
<body onload='load();'>
</body>
</html>
1.3338 +12 -0 WebKit/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebKit/ChangeLog,v
retrieving revision 1.3337
retrieving revision 1.3338
diff -u -r1.3337 -r1.3338
--- ChangeLog 4 Oct 2005 01:31:48 -0000 1.3337
+++ ChangeLog 4 Oct 2005 20:23:53 -0000 1.3338
@@ -1,3 +1,15 @@
+2005-10-04 Beth Dakin <bdakin at apple.com>
+
+ Reviewed by Darin
+
+ Fix for <rdar://problem/4285538> TOT fix for Denver Regression: Drawing glitch in the transparent dialog's cancel/ok
+ button in the widget manager.
+
+ * WebCoreSupport.subproj/WebImageData.m: Calls WKSetPatternPhaseInUserSpace() which is a new function that lies in
+ WebKitSystemInterface that and takes care of pattern-setting. Prevents
+ regression that occurred with image tiling in transparency layers.
+ (-[WebImageData tileInRect:fromPoint:context:]):
+
2005-10-03 Tim Omernick <tomernick at apple.com>
Reviewed by John Sullivan.
1.48 +1 -2 WebKit/WebCoreSupport.subproj/WebImageData.m
Index: WebImageData.m
===================================================================
RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebImageData.m,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -r1.47 -r1.48
--- WebImageData.m 5 Sep 2005 22:22:40 -0000 1.47
+++ WebImageData.m 4 Oct 2005 20:24:00 -0000 1.48
@@ -616,8 +616,7 @@
CGContextSaveGState (aContext);
CGPoint tileOrigin = CGPointMake(oneTileRect.origin.x, oneTileRect.origin.y);
- CGPoint transformedOrigin = CGPointApplyAffineTransform(tileOrigin, CGContextGetCTM(aContext));
- CGContextSetPatternPhase(aContext, CGSizeMake(transformedOrigin.x, transformedOrigin.y));
+ WKSetPatternPhaseInUserSpace(aContext, tileOrigin);
CGColorSpaceRef patternSpace = CGColorSpaceCreatePattern(NULL);
CGContextSetFillColorSpace(aContext, patternSpace);
More information about the webkit-changes
mailing list