[webkit-changes] cvs commit: SVGSupport/layout-tests/custom path-bad-data-expected.checksum path-bad-data-expected.png path-bad-data-expected.txt path-bad-data.svg

[Eric]

eseidel     05/10/03 01:55:24

  Modified:    .        ChangeLog
               ksvg2/svg svgpathparser.cpp
  Added:       layout-tests/custom path-bad-data-expected.checksum
                        path-bad-data-expected.png
                        path-bad-data-expected.txt path-bad-data.svg
  Log:
  Bug #: 5239
  Submitted by: Rob Buis  <rwlbuis at xs4all.nl>
  Reviewed by: eseidel
          Fixes hang, caused by path parser spinning forever.
          http://bugzilla.opendarwin.org/show_bug.cgi?id=5239
  
          * ksvg2/svg/svgpathparser.cpp:
          (SVGPathParser::parseSVG):
          * svg-tests/custom/path-bad-data-expected.checksum: Added.
          * svg-tests/custom/path-bad-data-expected.png: Added.
          * svg-tests/custom/path-bad-data-expected.txt: Added.
          * svg-tests/custom/path-bad-data.svg: Added.
  
  Revision  Changes    Path
  1.186     +14 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.185
  retrieving revision 1.186
  diff -u -r1.185 -r1.186
  --- ChangeLog	3 Oct 2005 06:21:36 -0000	1.185
  +++ ChangeLog	3 Oct 2005 08:55:22 -0000	1.186
  @@ -1,3 +1,17 @@
  +2005-10-03  Rob Buis  <rwlbuis at xs4all.nl>
  +
  +        Reviewed by eseidel.
  +
  +        Fixes hang, caused by path parser spinning forever.
  +        http://bugzilla.opendarwin.org/show_bug.cgi?id=5239
  +
  +        * ksvg2/svg/svgpathparser.cpp:
  +        (SVGPathParser::parseSVG):
  +        * svg-tests/custom/path-bad-data-expected.checksum: Added.
  +        * svg-tests/custom/path-bad-data-expected.png: Added.
  +        * svg-tests/custom/path-bad-data-expected.txt: Added.
  +        * svg-tests/custom/path-bad-data.svg: Added.
  +
   2005-10-02  Eric Seidel  <eseidel at apple.com>
   
          Reviewed by darin.
  
  
  
  1.4       +7 -0      SVGSupport/ksvg2/svg/svgpathparser.cpp
  
  Index: svgpathparser.cpp
  ===================================================================
  RCS file: /cvs/root/SVGSupport/ksvg2/svg/svgpathparser.cpp,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- svgpathparser.cpp	1 Sep 2005 07:35:56 -0000	1.3
  +++ svgpathparser.cpp	3 Oct 2005 08:55:23 -0000	1.4
  @@ -388,6 +388,13 @@
                           calculateArc( relative, curx, cury, angle, tox, toy, rx, ry, largeArc, sweep );
                       else
                           svgArcTo( tox, toy, rx, ry, angle, largeArc, sweep, !relative );
  +                    break;
  +                }
  +                default:
  +                {
  +                    fprintf(stderr, "ERROR: Unknown path command: %c (a: %d)\n", command, command);
  +                    fprintf(stderr, "ERROR: Path Data parsing stopped at character position %d\n", ptr - d.latin1());
  +                    return;
                   }
               }
   
  
  
  
  1.1                  SVGSupport/layout-tests/custom/path-bad-data-expected.checksum
  
  Index: path-bad-data-expected.checksum
  ===================================================================
  39641d78af44ea2bdf6538f89aff2426
  
  
  1.1                  SVGSupport/layout-tests/custom/path-bad-data-expected.png
  
  	<<Binary file>>
  
  
  1.1                  SVGSupport/layout-tests/custom/path-bad-data-expected.txt
  
  Index: path-bad-data-expected.txt
  ===================================================================
  KCanvasRegistry: empty
  KCanvasContainer at (0,-233) size 677x494
    KCanvasItem {path} at (0,-233) size 677x494 [fill={[type=SOLID] [color=#000000]}] [data="M602.78,261.43C677.31,100.20,602.79,-89.02,436.34,-161.21C269.89,-233.40,74.53,-161.22,0.00,-0.00"]
  
  
  
  1.1                  SVGSupport/layout-tests/custom/path-bad-data.svg
  
  Index: path-bad-data.svg
  ===================================================================
  <?xml version="1.0" encoding="UTF-8" standalone="no"?>
  <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 20010904//EN"
  "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd">
  <svg
     width="200mm"
     height="200mm"
     xmlns="http://www.w3.org/2000/svg">
     <path d="M 602.7771 261.4254 A 318.0399 308.0491 0 
 1 602.7771 261.4253"/>
  </svg>