[webkit-changes] cvs commit: SVGSupport/ksvg2/svg SVGDocumentImpl.cpp

[Eric]

eseidel     05/10/02 22:21:57

  Modified:    .        ChangeLog
               ksvg2/svg SVGDocumentImpl.cpp
  Log:
  Bug #: 5238
  Submitted by: eseidel
  Reviewed by: mjs
          Fix crash when encountering XML processing directives w/ KDOM:
          http://bugzilla.opendarwin.org/show_bug.cgi?id=5238
  
          * ksvg2/svg/SVGDocumentImpl.cpp:
          (SVGDocumentImpl::recalcStyleSelector): null check.
  
  Revision  Changes    Path
  1.182     +10 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.181
  retrieving revision 1.182
  diff -u -r1.181 -r1.182
  --- ChangeLog	2 Oct 2005 19:51:19 -0000	1.181
  +++ ChangeLog	3 Oct 2005 05:21:53 -0000	1.182
  @@ -1,5 +1,15 @@
   2005-10-02  Eric Seidel  <eseidel at apple.com>
   
  +        Reviewed by mjs.
  +
  +        Fix crash when encountering XML processing directives w/ KDOM:
  +        http://bugzilla.opendarwin.org/show_bug.cgi?id=5238
  +
  +        * ksvg2/svg/SVGDocumentImpl.cpp:
  +        (SVGDocumentImpl::recalcStyleSelector): null check.
  +
  +2005-10-02  Eric Seidel  <eseidel at apple.com>
  +
           Removing unused SVG source files.
   
           * WebCore.xcodeproj/project.pbxproj:
  
  
  
  1.9       +1 -1      SVGSupport/ksvg2/svg/SVGDocumentImpl.cpp
  
  Index: SVGDocumentImpl.cpp
  ===================================================================
  RCS file: /cvs/root/SVGSupport/ksvg2/svg/SVGDocumentImpl.cpp,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- SVGDocumentImpl.cpp	8 Sep 2005 08:03:34 -0000	1.8
  +++ SVGDocumentImpl.cpp	3 Oct 2005 05:21:57 -0000	1.9
  @@ -651,7 +651,7 @@
                   // Processing instruction (XML documents only)
                   KDOM::ProcessingInstructionImpl *pi = static_cast<KDOM::ProcessingInstructionImpl *>(n);
                   sheet = pi->sheet();
  -                if(!sheet && !pi->localHref()->isEmpty())
  +                if(!sheet && pi->localHref() && !pi->localHref()->isEmpty())
                   {
                       // Processing instruction with reference to an element in this document
                       // - e.g. <?xml-stylesheet href="#mystyle">, with the element