[webkit-changes] cvs commit: WebCore/khtml/xml dom_elementimpl.cpp

[Eric]

eseidel     05/11/30 15:04:14

  Modified:    .        ChangeLog
               khtml/xml dom_elementimpl.cpp
  Log:
  Bug #: 5890
  Submitted by: eseidel
  Reviewed by: darin
          No additional tests needed, acid2 covers this case.
  
          * khtml/xml/dom_elementimpl.cpp:
          (ElementImpl::rendererIsNeeded): call down into NodeImpl if needed.
  
  Revision  Changes    Path
  1.442     +9 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.441
  retrieving revision 1.442
  diff -u -r1.441 -r1.442
  --- ChangeLog	30 Nov 2005 11:49:30 -0000	1.441
  +++ ChangeLog	30 Nov 2005 23:04:07 -0000	1.442
  @@ -1,5 +1,14 @@
   2005-11-30  Eric Seidel  <eseidel at apple.com>
   
  +        Reviewed by darin.
  +
  +        No additional tests needed, acid2 covers this case.
  +
  +        * khtml/xml/dom_elementimpl.cpp:
  +        (ElementImpl::rendererIsNeeded): call down into NodeImpl if needed.
  +
  +2005-11-30  Eric Seidel  <eseidel at apple.com>
  +
           Reviewed by mjs.
   
           No functionality change, no tests needed.
  
  
  
  1.95      +2 -2      WebCore/khtml/xml/dom_elementimpl.cpp
  
  Index: dom_elementimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_elementimpl.cpp,v
  retrieving revision 1.94
  retrieving revision 1.95
  diff -u -r1.94 -r1.95
  --- dom_elementimpl.cpp	30 Nov 2005 11:49:39 -0000	1.94
  +++ dom_elementimpl.cpp	30 Nov 2005 23:04:14 -0000	1.95
  @@ -522,12 +522,12 @@
   }
   
   #if SVG_SUPPORT
  -bool ElementImpl::rendererIsNeeded(khtml::RenderStyle *)
  +bool ElementImpl::rendererIsNeeded(khtml::RenderStyle *style)
   {
       // SVG ignores arbitrary xml elements in its render tree contrary to the normal CSS/XML behavior.
       if ((KSVG::SVGNames::svgNamespaceURI == parentNode()->namespaceURI())) // FIXME: && !parentNode()->hasTagName(KSVG::SVGNames::foreignObjectTag)
           return false;
  -    return true;
  +    return NodeImpl::rendererIsNeeded(style);
   }
   #endif