[webkit-changes] cvs commit: WebCore/kwq KWQWidget.mm

[Beth]

bdakin      05/11/29 16:57:56

  Modified:    .        ChangeLog
               kwq      KWQWidget.mm
  Log:
  Bug #:
  
  Revision  Changes    Path
  1.434     +16 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.433
  retrieving revision 1.434
  diff -u -r1.433 -r1.434
  --- ChangeLog	30 Nov 2005 00:29:07 -0000	1.433
  +++ ChangeLog	30 Nov 2005 00:57:55 -0000	1.434
  @@ -1,3 +1,19 @@
  +2005-11-29  Beth Dakin  <bdakin at apple.com>
  +
  +        Reviewed by Darin
  +
  +        Fix for <rdar://problem/4098083> REGRESSION (125-312): crash 
  +	in [KWQTableView resignFirstResponder] selecting from JS menu 
  +	(car4you.at, etc.)
  +
  +	Though this crash is only currently reproducible on the branch
  +	and not on TOT, the fix should be in both. 
  +
  +        * kwq/KWQWidget.mm:
  +        (QWidget::removeFromSuperview): The call to removeFromSuperview
  +	could destroy data, so we should only reference it before the 
  +	call.
  +
   2005-11-30  Mitz Pettel  <opendarwin.org at mitzpettel.com>
   
           Reviewed by eseidel.  Committed by eseidel.
  
  
  
  1.114     +1 -1      WebCore/kwq/KWQWidget.mm
  
  Index: KWQWidget.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQWidget.mm,v
  retrieving revision 1.113
  retrieving revision 1.114
  diff -u -r1.113 -r1.114
  --- KWQWidget.mm	11 Oct 2005 19:16:45 -0000	1.113
  +++ KWQWidget.mm	30 Nov 2005 00:57:56 -0000	1.114
  @@ -569,10 +569,10 @@
       if (data->mustStayInWindow)
           data->removeFromSuperviewSoon = true;
       else {
  +        data->removeFromSuperviewSoon = false;
           KWQ_BLOCK_EXCEPTIONS;
           [getOuterView() removeFromSuperview];
           KWQ_UNBLOCK_EXCEPTIONS;
  -        data->removeFromSuperviewSoon = false;
       }
   }