[webkit-changes] cvs commit: LayoutTests/editing/style
block-style-004-expected.txt
Justin
justing at opensource.apple.com
Mon Nov 28 17:35:21 PST 2005
justing 05/11/28 17:35:21
Modified: . ChangeLog
editing/inserting insert-div-023-expected.txt
editing/pasteboard paste-4035648-fix-expected.txt
editing/selection 3690719-expected.checksum
3690719-expected.png 3690719-expected.txt
editing/style block-style-004-expected.txt
Added: editing/selection leave-requested-block-expected.checksum
leave-requested-block-expected.png
leave-requested-block-expected.txt
leave-requested-block.html
Log:
Fixed/added layout tests for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=5354>
Corner case where you can select outside the bounds of an editable block.
Reviewed by darin
* editing/inserting/insert-div-023-expected.txt:
* editing/pasteboard/paste-4035648-fix-expected.txt:
* editing/selection/3690719-expected.checksum:
* editing/selection/3690719-expected.png:
* editing/selection/3690719-expected.txt:
* editing/selection/leave-requested-block-expected.checksum: Added.
* editing/selection/leave-requested-block-expected.png: Added.
* editing/selection/leave-requested-block-expected.txt: Added.
* editing/selection/leave-requested-block.html: Added.
* editing/style/block-style-004-expected.txt:
Revision Changes Path
1.107 +19 -0 LayoutTests/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/LayoutTests/ChangeLog,v
retrieving revision 1.106
retrieving revision 1.107
diff -u -r1.106 -r1.107
--- ChangeLog 28 Nov 2005 20:03:59 -0000 1.106
+++ ChangeLog 29 Nov 2005 01:35:18 -0000 1.107
@@ -1,4 +1,23 @@
2005-11-28 Justin Garcia <justin.garcia at apple.com>
+
+ Fixed/added layout tests for:
+ <http://bugzilla.opendarwin.org/show_bug.cgi?id=5354>
+ Corner case where you can select outside the bounds of an editable block.
+
+ Reviewed by darin
+
+ * editing/inserting/insert-div-023-expected.txt:
+ * editing/pasteboard/paste-4035648-fix-expected.txt:
+ * editing/selection/3690719-expected.checksum:
+ * editing/selection/3690719-expected.png:
+ * editing/selection/3690719-expected.txt:
+ * editing/selection/leave-requested-block-expected.checksum: Added.
+ * editing/selection/leave-requested-block-expected.png: Added.
+ * editing/selection/leave-requested-block-expected.txt: Added.
+ * editing/selection/leave-requested-block.html: Added.
+ * editing/style/block-style-004-expected.txt:
+
+2005-11-28 Justin Garcia <justin.garcia at apple.com>
I overlooked this layout test when fixing 4108909.
1.9 +1 -0 LayoutTests/editing/inserting/insert-div-023-expected.txt
Index: insert-div-023-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/editing/inserting/insert-div-023-expected.txt,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- insert-div-023-expected.txt 17 Nov 2005 01:05:12 -0000 1.8
+++ insert-div-023-expected.txt 29 Nov 2005 01:35:19 -0000 1.9
@@ -17,6 +17,7 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of P > BODY > HTML > #document to 0 of P > BODY > HTML > #document toDOMRange:range from 0 of P > BODY > HTML > #document to 0 of P > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of BR to 0 of BR toDOMRange:range from 1 of #text > B > P > BODY > HTML > #document to 1 of #text > B > P > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
1.7 +2 -1 LayoutTests/editing/pasteboard/paste-4035648-fix-expected.txt
Index: paste-4035648-fix-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/editing/pasteboard/paste-4035648-fix-expected.txt,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- paste-4035648-fix-expected.txt 17 Nov 2005 01:05:25 -0000 1.6
+++ paste-4035648-fix-expected.txt 29 Nov 2005 01:35:19 -0000 1.7
@@ -47,7 +47,8 @@
RenderInline {B} at (0,0) size 45x28
RenderText {TEXT} at (2,30) size 45x28
text run at (2,30) width 45: "bold"
+ RenderInline {B} at (0,0) size 0x28
RenderBR {BR} at (0,0) size 0x0
RenderText {TEXT} at (2,58) size 49x28
text run at (2,58) width 49: "plain"
-caret: position 5 of child 2 {TEXT} of child 1 {DIV} of child 3 {DIV} of child 1 {BODY} of child 0 {HTML} of document
+caret: position 5 of child 3 {TEXT} of child 1 {DIV} of child 3 {DIV} of child 1 {BODY} of child 0 {HTML} of document
1.3 +1 -1 LayoutTests/editing/selection/3690719-expected.checksum
Index: 3690719-expected.checksum
===================================================================
RCS file: /cvs/root/LayoutTests/editing/selection/3690719-expected.checksum,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- 3690719-expected.checksum 22 Oct 2005 22:55:28 -0000 1.2
+++ 3690719-expected.checksum 29 Nov 2005 01:35:19 -0000 1.3
@@ -1 +1 @@
-d0e914bd352192b9c7183d5b72050e8c
\ No newline at end of file
+35810d7f795607272b4af3452332c614
\ No newline at end of file
1.3 +47 -41 LayoutTests/editing/selection/3690719-expected.png
<<Binary file>>
1.5 +2 -2 LayoutTests/editing/selection/3690719-expected.txt
Index: 3690719-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/editing/selection/3690719-expected.txt,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- 3690719-expected.txt 28 Oct 2005 11:46:41 -0000 1.4
+++ 3690719-expected.txt 29 Nov 2005 01:35:19 -0000 1.5
@@ -1,5 +1,5 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of TD > TR > TBODY > TABLE > DIV > CENTER > BODY > HTML > #document to 0 of TD > TR > TBODY > TABLE > DIV > CENTER > BODY > HTML > #document toDOMRange:range from 0 of #text > B > FONT > TD > TR > TBODY > TABLE > DIV > CENTER > BODY > HTML > #document to 6 of CENTER > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of TD > TR > TBODY > TABLE > DIV > CENTER > BODY > HTML > #document to 0 of TD > TR > TBODY > TABLE > DIV > CENTER > BODY > HTML > #document toDOMRange:range from 0 of #text > B > FONT > TD > TR > TBODY > TABLE > DIV > CENTER > BODY > HTML > #document to 1 of #text > FONT > DIV > CENTER > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
@@ -139,4 +139,4 @@
RenderText {TEXT} at (362,0) size 60x13
text run at (362,0) width 60: "\x{A9}2005 Google"
selection start: position 0 of child 0 {TEXT} of child 0 {B} of child 0 {FONT} of child 0 {TD} of child 0 {TR} of child 0 {TBODY} of child 1 {TABLE} of child 4 {DIV} of child 0 {CENTER} of child 1 {BODY} of child 0 {HTML} of document
-selection end: position 0 of child 6 {BR} of child 0 {CENTER} of child 1 {BODY} of child 0 {HTML} of document
+selection end: position 1 of child 3 {TEXT} of child 4 {FONT} of child 4 {DIV} of child 0 {CENTER} of child 1 {BODY} of child 0 {HTML} of document
1.1 LayoutTests/editing/selection/leave-requested-block-expected.checksum
Index: leave-requested-block-expected.checksum
===================================================================
ca85ee06268556851a0cb0e2fa6678c7
1.1 LayoutTests/editing/selection/leave-requested-block-expected.png
<<Binary file>>
1.1 LayoutTests/editing/selection/leave-requested-block-expected.txt
Index: leave-requested-block-expected.txt
===================================================================
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x576
RenderBlock {P} at (0,0) size 784x18
RenderText {TEXT} at (0,0) size 127x18
text run at (0,0) width 127: "Test case for fix for "
RenderInline {A} at (0,0) size 343x18 [color=#0000EE]
RenderText {TEXT} at (127,0) size 343x18
text run at (127,0) width 343: "http://bugzilla.opendarwin.org/show_bug.cgi?id=5354"
RenderText {TEXT} at (470,0) size 4x18
text run at (470,0) width 4: "."
RenderBlock {P} at (0,34) size 784x36
RenderText {TEXT} at (0,0) size 772x36
text run at (0,0) width 772: "Changes were made to VisiblePosition's so that init() will not leave the block containing the requested position unless there"
text run at (0,18) width 231: "are no VisiblePositions in that block."
RenderBlock {P} at (0,86) size 784x0
RenderBlock {DIV} at (0,86) size 784x54 [border: (2px solid #AAAAFF)]
RenderBlock {P} at (2,18) size 780x18
RenderText {TEXT} at (0,0) size 682x18
text run at (0,0) width 682: "Select All while inside this editable block should create a selection that does not extend outside of this block."
layer at (8,164) size 784x18
RenderBlock {P} at (0,156) size 784x18
RenderText {TEXT} at (0,0) size 424x18
text run at (0,0) width 424: "This is a paragraph outside the editable block with overflow:hidden"
selection start: position 0 of child 0 {TEXT} of child 1 {P} of child 5 {DIV} of child 1 {BODY} of child 0 {HTML} of document
selection end: position 113 of child 0 {TEXT} of child 1 {P} of child 5 {DIV} of child 1 {BODY} of child 0 {HTML} of document
1.1 LayoutTests/editing/selection/leave-requested-block.html
Index: leave-requested-block.html
===================================================================
<html>
<head>
<link rel=stylesheet href="../editingStyle.css" type="text/css">
<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script>
<script>
function editingTest() {
for (var i = 0; i < 30; i++) {
extendSelectionForwardByLineCommand();
}
}
</script>
<title>Editing Test</title>
</head>
<body>
<p>Test case for fix for <a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=5354">http://bugzilla.opendarwin.org/show_bug.cgi?id=5354</a>.</p>
<p>Changes were made to VisiblePosition's so that init() will not leave the block containing the requested position unless there are no VisiblePositions in that block.<p>
<div class="editableblock" id="test" contenteditable="true">
<p>Select All while inside this editable block should create a selection that does not extend outside of this block.</p>
</div>
<p style="overflow: hidden;">This is a paragraph outside the editable block with overflow:hidden</p>
<script>
runEditingTest();
</script>
</body>
</html>
1.12 +1 -0 LayoutTests/editing/style/block-style-004-expected.txt
Index: block-style-004-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/editing/style/block-style-004-expected.txt,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- block-style-004-expected.txt 17 Nov 2005 01:05:39 -0000 1.11
+++ block-style-004-expected.txt 29 Nov 2005 01:35:21 -0000 1.12
@@ -16,6 +16,7 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
More information about the webkit-changes
mailing list