[webkit-changes] cvs commit: JavaScriptCore/kjs value.cpp

[Adele]

adele       05/11/28 11:44:29

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               kjs      Tag: Safari-1-3-branch value.cpp
  Log:
          Fix by Darin, reviewed by me.
  
          fix for <rdar://problem/3885811> Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings) (4059)
  
          Changed the constructors to return the emtpy string if the string is null.
  
          * kjs/value.cpp:
          (String::String):
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.677.4.8 +11 -0     JavaScriptCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
  retrieving revision 1.677.4.7
  retrieving revision 1.677.4.8
  diff -u -r1.677.4.7 -r1.677.4.8
  --- ChangeLog	18 Nov 2005 00:56:30 -0000	1.677.4.7
  +++ ChangeLog	28 Nov 2005 19:44:23 -0000	1.677.4.8
  @@ -1,3 +1,14 @@
  +2005-11-28  Adele Peterson  <adele at apple.com>
  +
  +        Fix by Darin, reviewed by me.
  +        
  +        fix for <rdar://problem/3885811> Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings) (4059)
  +
  +        Changed the constructors to return the emtpy string if the string is null.
  +
  +        * kjs/value.cpp:
  +        (String::String):
  +
   === JavaScriptCore-312.2 ===
   
   2005-11-11  Timothy Hatcher  <timothy at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.23.8.1  +1 -1      JavaScriptCore/kjs/value.cpp
  
  Index: value.cpp
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/kjs/value.cpp,v
  retrieving revision 1.23
  retrieving revision 1.23.8.1
  diff -u -r1.23 -r1.23.8.1
  --- value.cpp	8 Dec 2004 22:54:45 -0000	1.23
  +++ value.cpp	28 Nov 2005 19:44:27 -0000	1.23.8.1
  @@ -356,7 +356,7 @@
   
   // ------------------------------ String ---------------------------------------
   
  -String::String(const UString &s) : Value(new StringImp(s))
  +String::String(const UString &s) : Value(new StringImp(s.isNull() ?"":s))
   {
   }