[webkit-changes] cvs commit: WebCore/khtml/xml dom_nodeimpl.cpp
Timothy
thatcher at opensource.apple.com
Fri Nov 18 10:27:13 PST 2005
thatcher 05/11/18 10:27:13
Modified: . Tag: Safari-1-3-branch ChangeLog
khtml/xml Tag: Safari-1-3-branch dom_nodeimpl.cpp
Log:
Reviewed by Dave Harrson.
Commited by Tim Hatcher.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5629
REGRESSION: appendChild() does not remove nodes from source
nodelist when inserting into destination
* khtml/rendering/render_layer.cpp:
(khtml::ContainerNodeImpl::appendChild): Dispatch old parent's
subtree modified event from appendChild()
Revision Changes Path
No revision
No revision
1.335.2.28 +13 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.335.2.27
retrieving revision 1.335.2.28
diff -u -r1.335.2.27 -r1.335.2.28
--- ChangeLog 18 Nov 2005 18:01:18 -0000 1.335.2.27
+++ ChangeLog 18 Nov 2005 18:27:07 -0000 1.335.2.28
@@ -1,3 +1,16 @@
+2005-11-18 Mitz Pettel <opendarwin.org at mitzpettel.com>
+
+ Reviewed by Dave Harrson.
+ Commited by Tim Hatcher.
+
+ - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5629
+ REGRESSION: appendChild() does not remove nodes from source
+ nodelist when inserting into destination
+
+ * khtml/rendering/render_layer.cpp:
+ (khtml::ContainerNodeImpl::appendChild): Dispatch old parent's
+ subtree modified event from appendChild()
+
2005-11-17 Timothy Hatcher <timothy at apple.com>
Merged fix from TOT to Safari-1-3-branch
No revision
No revision
1.140.6.3 +2 -0 WebCore/khtml/xml/dom_nodeimpl.cpp
Index: dom_nodeimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/xml/dom_nodeimpl.cpp,v
retrieving revision 1.140.6.2
retrieving revision 1.140.6.3
diff -u -r1.140.6.2 -r1.140.6.3
--- dom_nodeimpl.cpp 12 Nov 2005 01:31:01 -0000 1.140.6.2
+++ dom_nodeimpl.cpp 18 Nov 2005 18:27:11 -0000 1.140.6.3
@@ -1967,6 +1967,8 @@
child->attach();
getDocument()->allowEventDispatch();
+ if (oldParent)
+ oldParent->dispatchSubtreeModifiedEvent(true);
// Dispatch the mutation events
dispatchChildInsertedEvents(child,exceptioncode);
More information about the webkit-changes
mailing list