[webkit-changes] cvs commit: WebCore/kwq KWQComboBox.mm KWQListBox.mm

[Adele]

adele       05/11/15 12:02:29

  Modified:    .        ChangeLog
               kwq      KWQComboBox.mm KWQListBox.mm
  Log:
          Reviewed by Darin.
  
          - fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  
          * kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
          * kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.
  
  Revision  Changes    Path
  1.370     +9 -0      WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.369
  retrieving revision 1.370
  diff -u -r1.369 -r1.370
  --- ChangeLog	15 Nov 2005 19:15:16 -0000	1.369
  +++ ChangeLog	15 Nov 2005 20:02:22 -0000	1.370
  @@ -1,3 +1,12 @@
  +2005-11-15  Adele Peterson  <adele at apple.com>
  +
  +        Reviewed by Darin.
  +
  +        - fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  +
  +        * kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
  +        * kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.
  +
   2005-11-15  Alexey Proskuryakov  <ap at nypop.com>
           
           <http://bugzilla.opendarwin.org/show_bug.cgi?id=5717>
  
  
  
  1.74      +0 -5      WebCore/kwq/KWQComboBox.mm
  
  Index: KWQComboBox.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQComboBox.mm,v
  retrieving revision 1.73
  retrieving revision 1.74
  diff -u -r1.73 -r1.74
  --- KWQComboBox.mm	9 Nov 2005 23:05:09 -0000	1.73
  +++ KWQComboBox.mm	15 Nov 2005 20:02:27 -0000	1.74
  @@ -524,11 +524,6 @@
   {
       // Simplified method from NSView; overridden to replace NSView's way of checking
       // for full keyboard access with ours.
  -    QWidget *widget = [self widget];
  -    if (widget && !KWQKHTMLPart::partForWidget([self widget])->tabsToAllControls()) {
  -        return NO;
  -    }
  -    
       return ([self window] != nil) && ![self isHiddenOrHasHiddenAncestor] && [self acceptsFirstResponder];
   }
   
  
  
  
  1.67      +0 -3      WebCore/kwq/KWQListBox.mm
  
  Index: KWQListBox.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQListBox.mm,v
  retrieving revision 1.66
  retrieving revision 1.67
  diff -u -r1.66 -r1.67
  --- KWQListBox.mm	11 Nov 2005 23:35:17 -0000	1.66
  +++ KWQListBox.mm	15 Nov 2005 20:02:27 -0000	1.67
  @@ -605,9 +605,6 @@
   {
       // Simplified method from NSView; overridden to replace NSView's way of checking
       // for full keyboard access with ours.
  -    if (!_box || !KWQKHTMLPart::partForWidget(_box)->tabsToAllControls()) {
  -        return NO;
  -    }
       return ([self window] != nil) && ![self isHiddenOrHasHiddenAncestor] && [self acceptsFirstResponder];
   }