[webkit-changes] cvs commit: WebCore/kwq WebCoreBridge.mm

[Justin]

justing     05/11/15 11:15:21

  Modified:    .        ChangeLog
               kwq      WebCoreBridge.mm
  Log:
          <http://bugzilla.opendarwin.org/show_bug.cgi?id=5717>
          REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes
  
          Reviewed by justin
  
          * kwq/WebCoreBridge.mm:
          (-[WebCoreBridge _visiblePositionForPoint:]): Early return if node found by hitTest is null.
  
  Revision  Changes    Path
  1.369     +10 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.368
  retrieving revision 1.369
  diff -u -r1.368 -r1.369
  --- ChangeLog	15 Nov 2005 02:05:38 -0000	1.368
  +++ ChangeLog	15 Nov 2005 19:15:16 -0000	1.369
  @@ -1,3 +1,13 @@
  +2005-11-15  Alexey Proskuryakov  <ap at nypop.com>
  +        
  +        <http://bugzilla.opendarwin.org/show_bug.cgi?id=5717>
  +        REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes
  +        
  +        Reviewed by justin
  +
  +        * kwq/WebCoreBridge.mm:
  +        (-[WebCoreBridge _visiblePositionForPoint:]): Early return if node found by hitTest is null.
  +
   2005-11-14  Adele Peterson  <adele at apple.com>
   
           Reviewed by Maciej and Darin.
  
  
  
  1.430     +1 -1      WebCore/kwq/WebCoreBridge.mm
  
  Index: WebCoreBridge.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/WebCoreBridge.mm,v
  retrieving revision 1.429
  retrieving revision 1.430
  diff -u -r1.429 -r1.430
  --- WebCoreBridge.mm	14 Nov 2005 07:43:13 -0000	1.429
  +++ WebCoreBridge.mm	15 Nov 2005 19:15:20 -0000	1.430
  @@ -1953,7 +1953,7 @@
       RenderObject::NodeInfo nodeInfo(true, true);
       renderer->layer()->hitTest(nodeInfo, (int)point.x, (int)point.y);
       NodeImpl *node = nodeInfo.innerNode();
  -    if (!node->renderer())
  +    if (!node || !node->renderer())
           return VisiblePosition();
       
       return node->renderer()->positionForCoordinates((int)point.x, (int)point.y);