[webkit-changes] cvs commit: WebCore/khtml/html html_tableimpl.cpp
Timothy
thatcher at opensource.apple.com
Wed Nov 9 15:00:33 PST 2005
thatcher 05/11/09 15:00:32
Modified: . Tag: Safari-1-3-branch ChangeLog
khtml/html Tag: Safari-1-3-branch html_tableimpl.cpp
Log:
Merged fix from TOT to Safari-1-3-branch
2005-09-21 Vicki Murley <vicki at apple.com>
Reviewed by Darin.
- fix these bugs
<rdar://problem/3579812> HTMLTableElement.insertRow(n) inserts row at the beginning of the table (4043)
<rdar://problem/3711188> HTMLTableElement.insertRow() doesn't respect passed index
* khtml/html/html_tableimpl.cpp:
(DOM::HTMLTableElementImpl::insertRow):
if the index is the same as the number of rows in the section, we should append
Update test results for /fast/dynamic/013.html. In the old version the the rows
and cells were children of the first table section, a tfoot. They are now children
of the second table section, a tbody. Our rendering now matches Gecko and Win IE
(according to yusufg on #webkit, comparing with 013-expected.png) for this case.
* layout-tests/fast/dynamic/013-expected.checksum:
* layout-tests/fast/dynamic/013-expected.png:
* layout-tests/fast/dynamic/013-expected.txt:
Test cases added:
* layout-tests/fast/dynamic/014-expected.checksum: Added.
* layout-tests/fast/dynamic/014-expected.png: Added.
* layout-tests/fast/dynamic/014-expected.txt: Added.
* layout-tests/fast/dynamic/014.html: Added.
* layout-tests/fast/dynamic/015-expected.checksum: Added.
* layout-tests/fast/dynamic/015-expected.png: Added.
* layout-tests/fast/dynamic/015-expected.txt: Added.
* layout-tests/fast/dynamic/015.html: Added.
Revision Changes Path
No revision
No revision
1.335.2.5 +36 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.335.2.4
retrieving revision 1.335.2.5
diff -u -r1.335.2.4 -r1.335.2.5
--- ChangeLog 9 Nov 2005 22:51:28 -0000 1.335.2.4
+++ ChangeLog 9 Nov 2005 23:00:24 -0000 1.335.2.5
@@ -2,6 +2,42 @@
Merged fix from TOT to Safari-1-3-branch
+ 2005-09-21 Vicki Murley <vicki at apple.com>
+
+ Reviewed by Darin.
+
+ - fix these bugs
+ <rdar://problem/3579812> HTMLTableElement.insertRow(n) inserts row at the beginning of the table (4043)
+ <rdar://problem/3711188> HTMLTableElement.insertRow() doesn't respect passed index
+
+ * khtml/html/html_tableimpl.cpp:
+ (DOM::HTMLTableElementImpl::insertRow):
+ if the index is the same as the number of rows in the section, we should append
+
+ Update test results for /fast/dynamic/013.html. In the old version the the rows
+ and cells were children of the first table section, a tfoot. They are now children
+ of the second table section, a tbody. Our rendering now matches Gecko and Win IE
+ (according to yusufg on #webkit, comparing with 013-expected.png) for this case.
+
+ * layout-tests/fast/dynamic/013-expected.checksum:
+ * layout-tests/fast/dynamic/013-expected.png:
+ * layout-tests/fast/dynamic/013-expected.txt:
+
+ Test cases added:
+
+ * layout-tests/fast/dynamic/014-expected.checksum: Added.
+ * layout-tests/fast/dynamic/014-expected.png: Added.
+ * layout-tests/fast/dynamic/014-expected.txt: Added.
+ * layout-tests/fast/dynamic/014.html: Added.
+ * layout-tests/fast/dynamic/015-expected.checksum: Added.
+ * layout-tests/fast/dynamic/015-expected.png: Added.
+ * layout-tests/fast/dynamic/015-expected.txt: Added.
+ * layout-tests/fast/dynamic/015.html: Added.
+
+2005-11-09 Timothy Hatcher <timothy at apple.com>
+
+ Merged fix from TOT to Safari-1-3-branch
+
2005-09-16 Tim Omernick <tomernick at apple.com>
Reviewed by Dave Hyatt. Test case reviewed by Vicki Murley.
No revision
No revision
1.49.6.2 +2 -2 WebCore/khtml/html/html_tableimpl.cpp
Index: html_tableimpl.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/html/html_tableimpl.cpp,v
retrieving revision 1.49.6.1
retrieving revision 1.49.6.2
diff -u -r1.49.6.1 -r1.49.6.2
--- html_tableimpl.cpp 12 Jul 2005 20:58:48 -0000 1.49.6.1
+++ html_tableimpl.cpp 9 Nov 2005 23:00:31 -0000 1.49.6.2
@@ -237,8 +237,8 @@
if ( !append )
{
int rows = section->numRows();
- if ( rows > index ) {
- found = true;
+ if (rows >= index) {
+ found = true;
break;
} else
index -= rows;
More information about the webkit-changes
mailing list