[webkit-changes] cvs commit: WebCore/khtml/html html_objectimpl.cpp

[Timothy]

thatcher    05/11/09 14:37:17

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml/html Tag: Safari-2-0-branch html_objectimpl.cpp
  Log:
          Merged fix from TOT to Safari-2-0-branch
  
      2005-09-16  Tim Omernick  <tomernick at apple.com>
  
          Reviewed by Dave Hyatt.  Test case reviewed by Vicki Murley.
  
          <rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)
  
          Test cases added:
          * manual-tests/show-hide-object.html: Added.
          * manual-tests/resources/spinbox.swf: Added.
  
          * khtml/html/html_objectimpl.cpp:
          (DOM::HTMLObjectElementImpl::detach):
          Set needWidgetUpdate to true so that the widget is updated on the next attach().
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.1.2.40  +18 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.1.2.39
  retrieving revision 1.1.2.40
  diff -u -r1.1.2.39 -r1.1.2.40
  --- ChangeLog	21 Oct 2005 21:20:55 -0000	1.1.2.39
  +++ ChangeLog	9 Nov 2005 22:37:11 -0000	1.1.2.40
  @@ -1,3 +1,21 @@
  +2005-11-09  Timothy Hatcher  <timothy at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
  +
  +    2005-09-16  Tim Omernick  <tomernick at apple.com>
  +
  +        Reviewed by Dave Hyatt.  Test case reviewed by Vicki Murley.
  +
  +        <rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)
  +
  +        Test cases added:
  +        * manual-tests/show-hide-object.html: Added.
  +        * manual-tests/resources/spinbox.swf: Added.
  +
  +        * khtml/html/html_objectimpl.cpp:
  +        (DOM::HTMLObjectElementImpl::detach):
  +        Set needWidgetUpdate to true so that the widget is updated on the next attach().
  +
   === WebCore-417.4 ===
   
   2005-10-21  Timothy Hatcher  <timothy at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.60.8.3  +6 -2      WebCore/khtml/html/html_objectimpl.cpp
  
  Index: html_objectimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_objectimpl.cpp,v
  retrieving revision 1.60.8.2
  retrieving revision 1.60.8.3
  diff -u -r1.60.8.2 -r1.60.8.3
  --- html_objectimpl.cpp	13 Aug 2005 20:23:08 -0000	1.60.8.2
  +++ html_objectimpl.cpp	9 Nov 2005 22:37:16 -0000	1.60.8.3
  @@ -569,11 +569,15 @@
   void HTMLObjectElementImpl::detach()
   {
       // Only bother with an unload event if we had a render object.  - dwh
  -    if (attached() && m_render && !m_useFallbackContent)
  +    if (attached() && m_render && !m_useFallbackContent) {
           // ### do this when we are actualy removed from document instead
           dispatchHTMLEvent(EventImpl::UNLOAD_EVENT,false,false);
  +        
  +        // Update the widget the next time we attach (detaching destroys the plugin).
  +        needWidgetUpdate = true;
  +    }
   
  -  HTMLElementImpl::detach();
  +    HTMLElementImpl::detach();
   }
   
   void HTMLObjectElementImpl::recalcStyle(StyleChange ch)