[webkit-changes] cvs commit: LayoutTests/editing/inserting
insert-at-end-01-expected.checksum
insert-at-end-01-expected.png insert-at-end-01-expected.txt
insert-at-end-01.html insert-at-end-02-expected.checksum
insert-at-end-02-expected.png insert-at-end-02-expected.txt
insert-at-end-02.html insert-3786362-fix-expected.txt
Justin
justing at opensource.apple.com
Mon Nov 7 11:59:33 PST 2005
justing 05/11/07 11:59:33
Modified: . ChangeLog
editing/deleting
delete-at-paragraph-boundaries-011-expected.txt
delete-br-011-expected.checksum
delete-br-011-expected.png
delete-br-011-expected.txt
editing/inserting insert-3786362-fix-expected.txt
Added: editing/inserting insert-at-end-01-expected.checksum
insert-at-end-01-expected.png
insert-at-end-01-expected.txt insert-at-end-01.html
insert-at-end-02-expected.checksum
insert-at-end-02-expected.png
insert-at-end-02-expected.txt insert-at-end-02.html
Log:
Reviewed by harrison
New/updated layout tests for fixes for:
<rdar://problem/4125131> REGRESSION (Mail): after certain steps,
extra blank line appears when typing past end of reply-quoted text
<rdar://problem/4024996> Applying block styles can cause assertion
failure in inline style removal
* editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* editing/deleting/delete-br-011-expected.checksum:
* editing/deleting/delete-br-011-expected.png:
* editing/deleting/delete-br-011-expected.txt:
* editing/inserting/insert-3786362-fix-expected.txt:
* editing/inserting/insert-at-end-01-expected.checksum: Added.
* editing/inserting/insert-at-end-01-expected.png: Added.
* editing/inserting/insert-at-end-01-expected.txt: Added.
* editing/inserting/insert-at-end-01.html: Added.
* editing/inserting/insert-at-end-02-expected.checksum: Added.
* editing/inserting/insert-at-end-02-expected.png: Added.
* editing/inserting/insert-at-end-02-expected.txt: Added.
* editing/inserting/insert-at-end-02.html: Added.
Revision Changes Path
1.76 +25 -0 LayoutTests/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/LayoutTests/ChangeLog,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -r1.75 -r1.76
--- ChangeLog 6 Nov 2005 20:44:35 -0000 1.75
+++ ChangeLog 7 Nov 2005 19:59:31 -0000 1.76
@@ -1,3 +1,28 @@
+2005-11-07 Justin Garcia <justin.garcia at apple.com>
+
+ Reviewed by harrison
+
+ New/updated layout tests for fixes for:
+
+ <rdar://problem/4125131> REGRESSION (Mail): after certain steps,
+ extra blank line appears when typing past end of reply-quoted text
+ <rdar://problem/4024996> Applying block styles can cause assertion
+ failure in inline style removal
+
+ * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
+ * editing/deleting/delete-br-011-expected.checksum:
+ * editing/deleting/delete-br-011-expected.png:
+ * editing/deleting/delete-br-011-expected.txt:
+ * editing/inserting/insert-3786362-fix-expected.txt:
+ * editing/inserting/insert-at-end-01-expected.checksum: Added.
+ * editing/inserting/insert-at-end-01-expected.png: Added.
+ * editing/inserting/insert-at-end-01-expected.txt: Added.
+ * editing/inserting/insert-at-end-01.html: Added.
+ * editing/inserting/insert-at-end-02-expected.checksum: Added.
+ * editing/inserting/insert-at-end-02-expected.png: Added.
+ * editing/inserting/insert-at-end-02-expected.txt: Added.
+ * editing/inserting/insert-at-end-02.html: Added.
+
2005-11-06 Geoffrey Garen <ggaren at apple.com>
Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5571
1.4 +0 -1 LayoutTests/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt
Index: delete-at-paragraph-boundaries-011-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- delete-at-paragraph-boundaries-011-expected.txt 15 Aug 2005 03:39:29 -0000 1.3
+++ delete-at-paragraph-boundaries-011-expected.txt 7 Nov 2005 19:59:31 -0000 1.4
@@ -2,7 +2,6 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
1.2 +1 -1 LayoutTests/editing/deleting/delete-br-011-expected.checksum
Index: delete-br-011-expected.checksum
===================================================================
RCS file: /cvs/root/LayoutTests/editing/deleting/delete-br-011-expected.checksum,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- delete-br-011-expected.checksum 29 Aug 2005 05:55:11 -0000 1.1
+++ delete-br-011-expected.checksum 7 Nov 2005 19:59:31 -0000 1.2
@@ -1 +1 @@
-8a5b61aaa6fa4214695a5e27837d3747
\ No newline at end of file
+70fbd07ee83387037803c2effb194dfc
\ No newline at end of file
1.2 +1 -1 LayoutTests/editing/deleting/delete-br-011-expected.png
<<Binary file>>
1.4 +8 -9 LayoutTests/editing/deleting/delete-br-011-expected.txt
Index: delete-br-011-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/editing/deleting/delete-br-011-expected.txt,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- delete-br-011-expected.txt 15 Aug 2005 03:39:30 -0000 1.3
+++ delete-br-011-expected.txt 7 Nov 2005 19:59:31 -0000 1.4
@@ -1,8 +1,7 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of SPAN > FONT > BODY > HTML > #document to 1 of SPAN > FONT > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
@@ -10,10 +9,10 @@
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
- RenderBlock (anonymous) at (0,0) size 784x18
- RenderText {TEXT} at (0,0) size 31x18
- text run at (0,0) width 31: "hello"
- RenderBlock {DIV} at (0,18) size 784x56 [border: (2px solid #FF0000)]
- RenderBR {BR} at (14,14) size 0x28
- RenderBlock (anonymous) at (0,74) size 784x0
-caret: position 1 of child 0 {BR} of child 1 {DIV} of child 1 {BODY} of child 0 {HTML} of document
+ RenderText {TEXT} at (0,0) size 31x18
+ text run at (0,0) width 31: "hello"
+ RenderInline {FONT} at (0,0) size 0x18
+ RenderInline {SPAN} at (0,0) size 0x18
+ RenderBR {BR} at (0,0) size 0x0
+ RenderBR {BR} at (0,18) size 0x18
+caret: position 0 of child 2 {BR} of child 1 {BODY} of child 0 {HTML} of document
1.7 +2 -2 LayoutTests/editing/inserting/insert-3786362-fix-expected.txt
Index: insert-3786362-fix-expected.txt
===================================================================
RCS file: /cvs/root/LayoutTests/editing/inserting/insert-3786362-fix-expected.txt,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- insert-3786362-fix-expected.txt 15 Aug 2005 03:39:47 -0000 1.6
+++ insert-3786362-fix-expected.txt 7 Nov 2005 19:59:32 -0000 1.7
@@ -5,7 +5,7 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 4 of DIV > BODY > HTML > #document to 4 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 3 of DIV > BODY > HTML > #document to 3 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
@@ -26,4 +26,4 @@
RenderBR {BR} at (0,0) size 0x0
RenderBR {BR} at (2,30) size 0x28
RenderBR {BR} at (2,58) size 0x28
-caret: position 1 of child 3 {BR} of child 3 {DIV} of child 1 {BODY} of child 0 {HTML} of document
+caret: position 0 of child 3 {BR} of child 3 {DIV} of child 1 {BODY} of child 0 {HTML} of document
1.1 LayoutTests/editing/inserting/insert-at-end-01-expected.checksum
Index: insert-at-end-01-expected.checksum
===================================================================
814dbf31a717a100c5875e09b714b282
1.1 LayoutTests/editing/inserting/insert-at-end-01-expected.png
<<Binary file>>
1.1 LayoutTests/editing/inserting/insert-at-end-01-expected.txt
Index: insert-at-end-01-expected.txt
===================================================================
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {P} at (0,0) size 784x18
RenderText {TEXT} at (0,0) size 374x18
text run at (0,0) width 374: "This tests the visual position at the end of an editable block."
RenderBlock {P} at (0,34) size 784x36
RenderText {TEXT} at (0,0) size 717x36
text run at (0,0) width 590: "When the document ended with a <br>, there were visual positions at both [br, 0] and [br, 1]. "
text run at (590,0) width 127: "This would produce"
text run at (0,18) width 382: "inconsistent behavior when editing at the end of a document."
RenderBlock {DIV} at (0,86) size 784x66 [border: (2px solid #AAAAFF)]
RenderBlock {DIV} at (2,2) size 780x22 [border: (2px solid #FFAAAA)]
RenderText {TEXT} at (2,2) size 90x18
text run at (2,2) width 90: "paragraph one"
RenderBlock {DIV} at (2,24) size 780x22 [border: (2px solid #FFAAAA)]
RenderText {TEXT} at (2,2) size 91x18
text run at (2,2) width 91: "paragraph two"
RenderBlock (anonymous) at (2,46) size 780x18
RenderText {TEXT} at (0,0) size 8x18
text run at (0,0) width 8: "x"
RenderBR {BR} at (0,0) size 0x0
caret: position 1 of child 5 {TEXT} of child 5 {DIV} of child 1 {BODY} of child 0 {HTML} of document
1.1 LayoutTests/editing/inserting/insert-at-end-01.html
Index: insert-at-end-01.html
===================================================================
<html>
<head>
<link rel="stylesheet" href="../editingStyle.css">
<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script>
<script>
function editingTest() {
moveSelectionForwardByLineCommand();
moveSelectionForwardByLineCommand();
moveSelectionForwardByLineCommand();
moveSelectionForwardByLineCommand();
typeCharacterCommand();
}
</script>
<title>Editing Test</title>
</head>
<body>
<p>This tests the visual position at the end of an editable block.</p>
<p>When the document ended with a <br>, there were visual positions at both [br, 0] and [br, 1]. This would produce inconsistent behavior when editing at the end of a document.</p>
<div contenteditable id="test" class="editing">
<div>paragraph one</div>
<div>paragraph two</div>
<br></div>
<script>runEditingTest();</script>
</body></html>
1.1 LayoutTests/editing/inserting/insert-at-end-02-expected.checksum
Index: insert-at-end-02-expected.checksum
===================================================================
814dbf31a717a100c5875e09b714b282
1.1 LayoutTests/editing/inserting/insert-at-end-02-expected.png
<<Binary file>>
1.1 LayoutTests/editing/inserting/insert-at-end-02-expected.txt
Index: insert-at-end-02-expected.txt
===================================================================
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 1 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {P} at (0,0) size 784x18
RenderText {TEXT} at (0,0) size 374x18
text run at (0,0) width 374: "This tests the visual position at the end of an editable block."
RenderBlock {P} at (0,34) size 784x36
RenderText {TEXT} at (0,0) size 717x36
text run at (0,0) width 590: "When the document ended with a <br>, there were visual positions at both [br, 0] and [br, 1]. "
text run at (590,0) width 127: "This would produce"
text run at (0,18) width 382: "inconsistent behavior when editing at the end of a document."
RenderBlock {DIV} at (0,86) size 784x66 [border: (2px solid #AAAAFF)]
RenderBlock {DIV} at (2,2) size 780x22 [border: (2px solid #FFAAAA)]
RenderText {TEXT} at (2,2) size 90x18
text run at (2,2) width 90: "paragraph one"
RenderBlock {DIV} at (2,24) size 780x22 [border: (2px solid #FFAAAA)]
RenderText {TEXT} at (2,2) size 91x18
text run at (2,2) width 91: "paragraph two"
RenderBlock (anonymous) at (2,46) size 780x18
RenderText {TEXT} at (0,0) size 8x18
text run at (0,0) width 8: "x"
RenderBR {BR} at (0,0) size 0x0
caret: position 1 of child 5 {TEXT} of child 5 {DIV} of child 1 {BODY} of child 0 {HTML} of document
1.1 LayoutTests/editing/inserting/insert-at-end-02.html
Index: insert-at-end-02.html
===================================================================
<html>
<head>
<link rel="stylesheet" href="../editingStyle.css">
<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script>
<script>
function editingTest() {
moveSelectionForwardByLineCommand();
moveSelectionForwardByLineCommand();
moveSelectionForwardByLineCommand();
moveSelectionForwardByLineCommand();
typeCharacterCommand();
}
</script>
<title>Editing Test</title>
</head>
<body>
<p>This tests the visual position at the end of an editable block.</p>
<p>When the document ended with a <br>, there were visual positions at both [br, 0] and [br, 1]. This would produce inconsistent behavior when editing at the end of a document.</p>
<div contenteditable id="test" class="editing">
<div>paragraph one</div>
<div>paragraph two</div>
<br>
</div>
<script>runEditingTest();</script>
</body></html>
More information about the webkit-changes
mailing list