[webkit-changes] cvs commit: JavaScriptCore/bindings/objc objc_class.mm

Geoffrey ggaren at opensource.apple.com
Sat Nov 5 22:20:44 PST 2005


ggaren      05/11/05 22:20:43

  Modified:    .        ChangeLog
               bindings/objc objc_class.mm
  Log:
          Patch by Mitz Pettel, reviewed by Maciej.
  
          - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5357
            REGRESSION: Scriptable plugin hides properties of OBJECT element
  
          * bindings/objc/objc_class.mm:
          (KJS::Bindings::ObjcClass::fallbackObject):
  
  Revision  Changes    Path
  1.877     +10 -0     JavaScriptCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
  retrieving revision 1.876
  retrieving revision 1.877
  diff -u -r1.876 -r1.877
  --- ChangeLog	6 Nov 2005 05:48:43 -0000	1.876
  +++ ChangeLog	6 Nov 2005 06:20:41 -0000	1.877
  @@ -1,5 +1,15 @@
   2005-11-05  Geoffrey Garen  <ggaren at apple.com>
   
  +        Patch by Mitz Pettel, reviewed by Maciej.
  +
  +        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5357
  +          REGRESSION: Scriptable plugin hides properties of OBJECT element
  +
  +        * bindings/objc/objc_class.mm:
  +        (KJS::Bindings::ObjcClass::fallbackObject):
  +
  +2005-11-05  Geoffrey Garen  <ggaren at apple.com>
  +
           Reviewed by Darin.
   
           - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5409
  
  
  
  1.12      +6 -1      JavaScriptCore/bindings/objc/objc_class.mm
  
  Index: objc_class.mm
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/bindings/objc/objc_class.mm,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- objc_class.mm	3 Oct 2005 21:11:46 -0000	1.11
  +++ objc_class.mm	6 Nov 2005 06:20:43 -0000	1.12
  @@ -236,7 +236,12 @@
   
   ValueImp *ObjcClass::fallbackObject (ExecState *exec, Instance *instance, const Identifier &propertyName)
   {
  -    return new ObjcFallbackObjectImp(static_cast<ObjcInstance*>(instance), propertyName);
  +    ObjcInstance * objcInstance = static_cast<ObjcInstance*>(instance);
  +    id targetObject = objcInstance->getObject();
  +    
  +    if (![targetObject respondsToSelector:@selector(invokeUndefinedMethodFromWebScript:withArguments:)])
  +        return jsUndefined();
  +    return new ObjcFallbackObjectImp(objcInstance, propertyName);
   }
   
   }
  
  
  



More information about the webkit-changes mailing list