[webkit-changes] cvs commit: WebCore/kwq WebCoreBridge.mm

[Justin]

justing     05/11/01 11:19:37

  Modified:    .        ChangeLog
               kwq      WebCoreBridge.mm
  Log:
          Reviewed by darin
  
          No test cases added, requires Mail
  
          * kwq/WebCoreBridge.mm:
          (-[WebCoreBridge typingStyle]):
          Crashes were happening after a style was merged with itself.  Mail was doing a setTypingStyle
          with a pointer to our internal typing style.  Fix is to only hand out copies of our typingStyle.
  
  Revision  Changes    Path
  1.323     +11 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.322
  retrieving revision 1.323
  diff -u -r1.322 -r1.323
  --- ChangeLog	1 Nov 2005 19:04:18 -0000	1.322
  +++ ChangeLog	1 Nov 2005 19:19:33 -0000	1.323
  @@ -1,5 +1,16 @@
   2005-11-01  Justin Garcia  <justin.garcia at apple.com>
   
  +        Reviewed by darin
  +        
  +        No test cases added, requires Mail
  +
  +        * kwq/WebCoreBridge.mm:
  +        (-[WebCoreBridge typingStyle]):
  +        Crashes were happening after a style was merged with itself.  Mail was doing a setTypingStyle
  +        with a pointer to our internal typing style.  Fix is to only hand out copies of our typingStyle.
  +
  +2005-11-01  Justin Garcia  <justin.garcia at apple.com>
  +
           Reviewed by harrison
           
           Fixed <rdar://problem/3690705> caret does not move when scrolling overflow: auto editable area
  
  
  
  1.423     +1 -1      WebCore/kwq/WebCoreBridge.mm
  
  Index: WebCoreBridge.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/WebCoreBridge.mm,v
  retrieving revision 1.422
  retrieving revision 1.423
  diff -u -r1.422 -r1.423
  --- WebCoreBridge.mm	28 Oct 2005 17:35:43 -0000	1.422
  +++ WebCoreBridge.mm	1 Nov 2005 19:19:37 -0000	1.423
  @@ -1989,7 +1989,7 @@
   {
       if (!_part || !_part->typingStyle())
           return nil;
  -    return [DOMCSSStyleDeclaration _styleDeclarationWithImpl:_part->typingStyle()];
  +    return [DOMCSSStyleDeclaration _styleDeclarationWithImpl:_part->typingStyle()->copy()];
   }
   
   - (void)setTypingStyle:(DOMCSSStyleDeclaration *)style withUndoAction:(WebUndoAction)undoAction