[webkit-changes] cvs commit: WebKit/WebCoreSupport.subproj WebTextRenderer.m

[Darin]

darin       05/06/22 09:44:08

  Modified:    .        ChangeLog
               WebCoreSupport.subproj WebTextRenderer.m
  Log:
          Change by Mitz Pettel.
          Reviewed by me.
  
          - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3618>
            RTL runs drawn by CG not reversed properly
  
          * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:geometry:]):
          Fix off-by-one mistake in order-swapping loops.
  
  Revision  Changes    Path
  1.3203    +11 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3202
  retrieving revision 1.3203
  diff -u -r1.3202 -r1.3203
  --- ChangeLog	22 Jun 2005 16:19:57 -0000	1.3202
  +++ ChangeLog	22 Jun 2005 16:44:04 -0000	1.3203
  @@ -1,5 +1,16 @@
   2005-06-22  Darin Adler  <darin at apple.com>
   
  +        Change by Mitz Pettel.
  +        Reviewed by me.
  +
  +        - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3618>
  +          RTL runs drawn by CG not reversed properly
  +
  +        * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:geometry:]):
  +        Fix off-by-one mistake in order-swapping loops.
  +
  +2005-06-22  Darin Adler  <darin at apple.com>
  +
           Change by Michael Gaiman.
           Reviewed by me.
   
  
  
  
  1.175     +3 -3      WebKit/WebCoreSupport.subproj/WebTextRenderer.m
  
  Index: WebTextRenderer.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebTextRenderer.m,v
  retrieving revision 1.174
  retrieving revision 1.175
  diff -u -r1.174 -r1.175
  --- WebTextRenderer.m	20 Jun 2005 01:20:01 -0000	1.174
  +++ WebTextRenderer.m	22 Jun 2005 16:44:08 -0000	1.175
  @@ -1102,19 +1102,19 @@
           CGSize aswap1, aswap2;
           NSFont *fswap1, *fswap2;
           
  -        for (i = pos, end = numGlyphs-1; i < (numGlyphs - pos)/2; i++){
  +        for (i = pos, end = numGlyphs; i < (numGlyphs - pos)/2; i++){
               gswap1 = glyphBuffer[i];
               gswap2 = glyphBuffer[--end];
               glyphBuffer[i] = gswap2;
               glyphBuffer[end] = gswap1;
           }
  -        for (i = pos, end = numGlyphs - 1; i < (numGlyphs - pos)/2; i++){
  +        for (i = pos, end = numGlyphs; i < (numGlyphs - pos)/2; i++){
               aswap1 = advances[i];
               aswap2 = advances[--end];
               advances[i] = aswap2;
               advances[end] = aswap1;
           }
  -        for (i = pos, end = numGlyphs - 1; i < (numGlyphs - pos)/2; i++){
  +        for (i = pos, end = numGlyphs; i < (numGlyphs - pos)/2; i++){
               fswap1 = fontBuffer[i];
               fswap2 = fontBuffer[--end];
               fontBuffer[i] = fswap2;