[webkit-changes] cvs commit: JavaScriptCore/bindings/objc WebScriptObject.mm

Darin darin at opensource.apple.com
Sat Jun 18 19:57:29 PDT 2005


darin       05/06/18 19:57:29

  Modified:    .        ChangeLog
               bindings/objc WebScriptObject.mm
  Log:
          Change by Finlay Dobbie.
          Reviewed by me.
  
          - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3331>
            10.3.9 Build Failure: NSString may not respond to `+stringWithCString:encoding:'
  
          * bindings/objc/WebScriptObject.mm: (-[WebScriptObject stringRepresentation]):
          Undo change we did a while back to work around the gcc 3.3 compiler error.
          It no longer seems to happen, and the workaround code was 10.4-specific.
  
  Revision  Changes    Path
  1.713     +12 -0     JavaScriptCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/ChangeLog,v
  retrieving revision 1.712
  retrieving revision 1.713
  diff -u -r1.712 -r1.713
  --- ChangeLog	17 Jun 2005 00:57:36 -0000	1.712
  +++ ChangeLog	19 Jun 2005 02:57:28 -0000	1.713
  @@ -1,3 +1,15 @@
  +2005-06-18  Darin Adler  <darin at apple.com>
  +
  +        Change by Finlay Dobbie.
  +        Reviewed by me.
  +
  +        - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3331>
  +          10.3.9 Build Failure: NSString may not respond to `+stringWithCString:encoding:'
  +
  +        * bindings/objc/WebScriptObject.mm: (-[WebScriptObject stringRepresentation]):
  +        Undo change we did a while back to work around the gcc 3.3 compiler error.
  +        It no longer seems to happen, and the workaround code was 10.4-specific.
  +
   2005-06-16  Geoffrey Garen  <ggaren at apple.com>
   
   	Fixed: <rdar://problem/4151759> 'delete' fails on variables declared inside 'eval' statements.
  
  
  
  1.19      +1 -1      JavaScriptCore/bindings/objc/WebScriptObject.mm
  
  Index: WebScriptObject.mm
  ===================================================================
  RCS file: /cvs/root/JavaScriptCore/bindings/objc/WebScriptObject.mm,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- WebScriptObject.mm	9 May 2005 18:46:43 -0000	1.18
  +++ WebScriptObject.mm	19 Jun 2005 02:57:29 -0000	1.19
  @@ -340,7 +340,7 @@
   {
       if (![self _isSafeScript])
           // This is a workaround for a gcc 3.3 internal compiler error.
  -	return [NSString stringWithCString:"Undefined" encoding:NSASCIIStringEncoding];
  +	return @"Undefined";
   
       Interpreter::lock();
       Object thisObj = Object(const_cast<ObjectImp*>([self _imp]));
  
  
  



More information about the webkit-changes mailing list