[webkit-changes] cvs commit: WebCore/khtml/rendering render_form.cpp

[Vicki]

vicki       05/06/17 16:02:48

  Modified:    .        ChangeLog
               khtml/rendering render_form.cpp
  Log:
          Reviewed by Maciej.
  
          Test cases added: None, since this test requires manual interaction.
  
  	- fixed <rdar://problem/4086793> Selects wrapped by Span or Label elements
  	do not resize when options are added via javascript
  
  	* khtml/rendering/render_form.cpp:
          (RenderSelect::layout): remove call setting setNeedsLayout to true.  setNeedsLayout
  	is already true at this point, and this addtional call has the negative effect of
  	marking m_normalChildNeedsLayout on the element's parent, which keeps layout from
  	propagating all the way up to the root later on.
  
  Revision  Changes    Path
  1.4274    +15 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4273
  retrieving revision 1.4274
  diff -u -r1.4273 -r1.4274
  --- ChangeLog	17 Jun 2005 21:55:35 -0000	1.4273
  +++ ChangeLog	17 Jun 2005 23:02:44 -0000	1.4274
  @@ -1,3 +1,18 @@
  +2005-06-17  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Maciej. 
  +
  +        Test cases added: None, since this test requires manual interaction.
  +
  +	- fixed <rdar://problem/4086793> Selects wrapped by Span or Label elements 
  +	do not resize when options are added via javascript
  +        
  +	* khtml/rendering/render_form.cpp:
  +        (RenderSelect::layout): remove call setting setNeedsLayout to true.  setNeedsLayout
  +	is already true at this point, and this addtional call has the negative effect of 
  +	marking m_normalChildNeedsLayout on the element's parent, which keeps layout from 
  +	propagating all the way up to the root later on.
  +
   2005-06-17  Justin Garcia  <justin.garcia at apple.com>
   
   	Fix for rdar://3756860, (also listed as) http://bugzilla.opendarwin.org/show_bug.cgi?id=3295
  
  
  
  1.106     +0 -2      WebCore/khtml/rendering/render_form.cpp
  
  Index: render_form.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_form.cpp,v
  retrieving revision 1.105
  retrieving revision 1.106
  diff -u -r1.105 -r1.106
  --- render_form.cpp	18 May 2005 21:10:24 -0000	1.105
  +++ render_form.cpp	17 Jun 2005 23:02:48 -0000	1.106
  @@ -1280,8 +1280,6 @@
           setIntrinsicHeight( s.height() );
       }
   
  -    /// uuh, ignore the following line..
  -    setNeedsLayout(true);
       RenderFormElement::layout();
   
       // and now disable the widget in case there is no <option> given