[webkit-changes] cvs commit: WebCore/khtml/html html_formimpl.cpp html_formimpl.h

[Geoffrey]

ggaren      05/06/17 11:14:27

  Modified:    .        ChangeLog
               khtml/html html_formimpl.cpp html_formimpl.h
  Log:
  	Patch contributed by Joos de Valk <webkit at joostdevalk.nl>.
  
  	Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=3408
  
          Reviewed by Darin.
  
          Test cases added: None. Test requires manual interaction.
  	Manual test available at: http://bugzilla.opendarwin.org/attachment.cgi?id=2207
  
          * khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
          * khtml/html/html_formimpl.h: Ditto.
  
  Revision  Changes    Path
  1.4269    +14 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4268
  retrieving revision 1.4269
  diff -u -r1.4268 -r1.4269
  --- ChangeLog	17 Jun 2005 16:41:01 -0000	1.4268
  +++ ChangeLog	17 Jun 2005 18:14:22 -0000	1.4269
  @@ -1,3 +1,17 @@
  +2005-06-17  Geoffrey Garen  <ggaren at apple.com>
  +
  +	Patch contributed by Joos de Valk <webkit at joostdevalk.nl>.
  +
  +	Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=3408	
  +
  +        Reviewed by Darin.
  +
  +        Test cases added: None. Test requires manual interaction.
  +	Manual test available at: http://bugzilla.opendarwin.org/attachment.cgi?id=2207
  +
  +        * khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click. 
  +        * khtml/html/html_formimpl.h: Ditto.
  +
   2005-06-17  Darin Adler  <darin at apple.com>
   
           Reviewed by John.
  
  
  
  1.162     +0 -13     WebCore/khtml/html/html_formimpl.cpp
  
  Index: html_formimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.cpp,v
  retrieving revision 1.161
  retrieving revision 1.162
  diff -u -r1.161 -r1.162
  --- html_formimpl.cpp	31 May 2005 05:48:41 -0000	1.161
  +++ html_formimpl.cpp	17 Jun 2005 18:14:27 -0000	1.162
  @@ -1267,19 +1267,6 @@
       return true;
   }
   
  -void HTMLButtonElementImpl::click(bool sendMouseEvents)
  -{
  -#if APPLE_CHANGES
  -    QWidget *widget;
  -    if (renderer() && (widget = static_cast<RenderWidget *>(renderer())->widget())) {
  -        // using this method gives us nice Cocoa user interface feedback
  -        static_cast<QButton *>(widget)->click(sendMouseEvents);
  -    }
  -    else
  -#endif
  -        HTMLGenericFormElementImpl::click(sendMouseEvents);
  -}
  -
   void HTMLButtonElementImpl::accessKeyAction(bool sendToAnyElement)
   {   
       // send the mouse button events iff the
  
  
  
  1.72      +0 -1      WebCore/khtml/html/html_formimpl.h
  
  Index: html_formimpl.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_formimpl.h,v
  retrieving revision 1.71
  retrieving revision 1.72
  diff -u -r1.71 -r1.72
  --- html_formimpl.h	12 May 2005 17:11:22 -0000	1.71
  +++ html_formimpl.h	17 Jun 2005 18:14:27 -0000	1.72
  @@ -253,7 +253,6 @@
       virtual bool isActivatedSubmit() const;
       virtual void setActivatedSubmit(bool flag);
   
  -    virtual void click(bool sendMouseEvents);
       virtual void accessKeyAction(bool sendToAnyElement);
   
       DOMString accessKey() const;