[Webkit-changes] cvs commit: WebKit/Plugins.subproj WebBasePluginPackage.m

[Darin]

darin       05/06/05 20:44:55

  Modified:    .        ChangeLog
               Plugins.subproj WebBasePluginPackage.m
  Log:
          Reviewed by Hyatt.
  
          - fixed crash in Acid2 layout test
  
          * Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Added nil check for CFBundleRef.
  
  Revision  Changes    Path
  1.3171    +8 -0      WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3170
  retrieving revision 1.3171
  diff -u -r1.3170 -r1.3171
  --- ChangeLog	6 Jun 2005 03:25:03 -0000	1.3170
  +++ ChangeLog	6 Jun 2005 03:44:52 -0000	1.3171
  @@ -2,6 +2,14 @@
   
           Reviewed by Hyatt.
   
  +        - fixed crash in Acid2 layout test
  +
  +        * Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Added nil check for CFBundleRef.
  +
  +2005-06-05  Darin Adler  <darin at apple.com>
  +
  +        Reviewed by Hyatt.
  +
   	- remove more SPI usage
   
           * Carbon.subproj/CarbonWindowAdapter.m: Remove a bunch of stuff.
  
  
  
  1.24      +3 -2      WebKit/Plugins.subproj/WebBasePluginPackage.m
  
  Index: WebBasePluginPackage.m
  ===================================================================
  RCS file: /cvs/root/WebKit/Plugins.subproj/WebBasePluginPackage.m,v
  retrieving revision 1.23
  retrieving revision 1.24
  diff -u -r1.23 -r1.24
  --- WebBasePluginPackage.m	5 Jun 2005 17:54:34 -0000	1.23
  +++ WebBasePluginPackage.m	6 Jun 2005 03:44:54 -0000	1.24
  @@ -98,7 +98,7 @@
       extensionToMIME = [[NSMutableDictionary alloc] init];
       path = [[self pathByResolvingSymlinksAndAliasesInPath:pluginPath] retain];
       bundle = [[NSBundle alloc] initWithPath:path];
  -	cfBundle = CFBundleCreate(NULL, (CFURLRef)[NSURL fileURLWithPath:path]);
  +    cfBundle = CFBundleCreate(NULL, (CFURLRef)[NSURL fileURLWithPath:path]);
       lastModifiedDate = [[[[NSFileManager defaultManager] fileAttributesAtPath:path traverseLink:YES] objectForKey:NSFileModificationDate] retain];
       return self;
   }
  @@ -247,7 +247,8 @@
       [extensionToMIME release];
   
       [bundle release];
  -	CFRelease(cfBundle);
  +    if (cfBundle)
  +        CFRelease(cfBundle);
   
       [lastModifiedDate release];