[webkit-changes] cvs commit: WebKit/WebView.subproj WebHTMLRepresentation.h WebHTMLRepresentation.m

[John]

sullivan    05/07/28 13:30:38

  Modified:    .        ChangeLog
               WebView.subproj WebHTMLRepresentation.h
                        WebHTMLRepresentation.m
  Log:
          Reviewed by Beth Dakin.
  
          - removed method -[WebHTMLRepresentation elementForView:], which was SPI used only for
          Safari autofill. Tip of tree Safari no longer includes any calls to this method. Also,
          Tiger Safari never gets around to actually calling it due to the other recent form-SPI-related
          changes, so removing this method doesn't break Tiger Safari running on tip of tree WebKit
          (though autofill continues to not work in that configuration).
  
          * WebView.subproj/WebHTMLRepresentation.h:
          * WebView.subproj/WebHTMLRepresentation.m:
          (-[WebHTMLRepresentation elementForView:]): removed
  
  Revision  Changes    Path
  1.3264    +14 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3263
  retrieving revision 1.3264
  diff -u -r1.3263 -r1.3264
  --- ChangeLog	27 Jul 2005 22:35:51 -0000	1.3263
  +++ ChangeLog	28 Jul 2005 20:30:35 -0000	1.3264
  @@ -1,3 +1,17 @@
  +2005-07-28  John Sullivan  <sullivan at apple.com>
  +
  +        Reviewed by Beth Dakin.
  +        
  +        - removed method -[WebHTMLRepresentation elementForView:], which was SPI used only for
  +        Safari autofill. Tip of tree Safari no longer includes any calls to this method. Also, 
  +        Tiger Safari never gets around to actually calling it due to the other recent form-SPI-related
  +        changes, so removing this method doesn't break Tiger Safari running on tip of tree WebKit
  +        (though autofill continues to not work in that configuration).
  +
  +        * WebView.subproj/WebHTMLRepresentation.h:
  +        * WebView.subproj/WebHTMLRepresentation.m:
  +        (-[WebHTMLRepresentation elementForView:]): removed
  +        
   2005-07-27  John Sullivan  <sullivan at apple.com>
   
   	Patch by Trey Matteson <trey at usa.net>
  
  
  
  1.29      +0 -1      WebKit/WebView.subproj/WebHTMLRepresentation.h
  
  Index: WebHTMLRepresentation.h
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebHTMLRepresentation.h,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- WebHTMLRepresentation.h	22 Jul 2005 18:09:25 -0000	1.28
  +++ WebHTMLRepresentation.h	28 Jul 2005 20:30:37 -0000	1.29
  @@ -51,7 +51,6 @@
   - (NSAttributedString *)attributedStringFrom:(DOMNode *)startNode startOffset:(int)startOffset to:(DOMNode *)endNode endOffset:(int)endOffset;
   
   - (DOMElement *)elementWithName:(NSString *)name inForm:(DOMElement *)form;
  -- (DOMElement *)elementForView:(NSView *)view;
   - (NSView *)viewForElement:(DOMElement *)element; // introduced temporarily to ease transition to view-free form SPI
   - (BOOL)elementDoesAutoComplete:(DOMElement *)element;
   - (BOOL)elementIsPassword:(DOMElement *)element;
  
  
  
  1.56      +0 -5      WebKit/WebView.subproj/WebHTMLRepresentation.m
  
  Index: WebHTMLRepresentation.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebHTMLRepresentation.m,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- WebHTMLRepresentation.m	22 Jul 2005 18:09:25 -0000	1.55
  +++ WebHTMLRepresentation.m	28 Jul 2005 20:30:37 -0000	1.56
  @@ -208,11 +208,6 @@
       return [_private->bridge elementWithName:name inForm:form];
   }
   
  -- (DOMElement *)elementForView:(NSView *)view
  -{
  -    return [_private->bridge elementForView:view];
  -}
  -
   - (NSView *)viewForElement:(DOMElement *)element
   {
       return [_private->bridge viewForElement:element];