[webkit-changes] cvs commit: WebKit/WebView.subproj WebFormDelegate.h WebFormDelegate.m

John sullivan at opensource.apple.com
Tue Jul 26 10:37:25 PDT 2005


sullivan    05/07/26 10:37:25

  Modified:    .        ChangeLog
               kwq      KWQTextField.mm WebCoreBridge.h
               .        ChangeLog
               WebCoreSupport.subproj WebBridge.m
               WebView.subproj WebFormDelegate.h WebFormDelegate.m
  Log:
  WebCore:
  
          Reviewed by Chris Blumenberg.
  
          Test cases added: none, only affects Safari autofill
  
          - more work to wean form-related SPI from NSView. All that's left (but this is a big "all")
          is viewForElement: and elementForView:
  
          * kwq/WebCoreBridge.h:
          Rename control:textView:doCommandBySelector: to textField:doCommandBySelector:, and changed
          to take DOMHTMLInputElement* rather than NSControl* and NSTextView*
  
          * kwq/KWQTextField.mm:
          (-[KWQTextFieldController control:textView:doCommandBySelector:]):
          call renamed bridge method, passing DOMElement* instead of NSView*
  
  WebKit:
  
          Reviewed by Chris Blumenberg.
  
          - more work to wean form-related SPI from NSView. All that's left (but this is a big "all")
          is viewForElement: and elementForView:
  
          * WebCoreSupport.subproj/WebBridge.m:
          (-[WebBridge textField:doCommandBySelector:]):
          changed signature to pass along DOMElement* rather than NSView*
  
          * WebView.subproj/WebFormDelegate.h:
          * WebView.subproj/WebFormDelegate.m:
          (-[WebFormDelegate textField:doCommandBySelector:inFrame:]):
          ditto
  
  Revision  Changes    Path
  1.4472    +17 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4471
  retrieving revision 1.4472
  diff -u -r1.4471 -r1.4472
  --- ChangeLog	26 Jul 2005 16:34:09 -0000	1.4471
  +++ ChangeLog	26 Jul 2005 17:37:17 -0000	1.4472
  @@ -1,5 +1,22 @@
   2005-07-26  John Sullivan  <sullivan at apple.com>
   
  +        Reviewed by Chris Blumenberg.
  +
  +        Test cases added: none, only affects Safari autofill
  +        
  +        - more work to wean form-related SPI from NSView. All that's left (but this is a big "all")
  +        is viewForElement: and elementForView:
  +
  +        * kwq/WebCoreBridge.h:
  +        Rename control:textView:doCommandBySelector: to textField:doCommandBySelector:, and changed
  +        to take DOMHTMLInputElement* rather than NSControl* and NSTextView*
  +
  +        * kwq/KWQTextField.mm:
  +        (-[KWQTextFieldController control:textView:doCommandBySelector:]):
  +        call renamed bridge method, passing DOMElement* instead of NSView*
  +
  +2005-07-26  John Sullivan  <sullivan at apple.com>
  +
           Reviewed by Darin Adler.
   
           Test cases added: none, only affects Safari autofill
  
  
  
  1.84      +1 -1      WebCore/kwq/KWQTextField.mm
  
  Index: KWQTextField.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQTextField.mm,v
  retrieving revision 1.83
  retrieving revision 1.84
  diff -u -r1.83 -r1.84
  --- KWQTextField.mm	26 Jul 2005 16:34:13 -0000	1.83
  +++ KWQTextField.mm	26 Jul 2005 17:37:21 -0000	1.84
  @@ -225,7 +225,7 @@
   	return NO;
       
       WebCoreBridge *bridge = KWQKHTMLPart::bridgeForWidget(widget);
  -    return [bridge control:control textView:textView doCommandBySelector:commandSelector];
  +    return [bridge textField:(DOMHTMLInputElement *)[bridge elementForView:field] doCommandBySelector:commandSelector];
   }
   
   - (void)textChanged
  
  
  
  1.342     +1 -1      WebCore/kwq/WebCoreBridge.h
  
  Index: WebCoreBridge.h
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/WebCoreBridge.h,v
  retrieving revision 1.341
  retrieving revision 1.342
  diff -u -r1.341 -r1.342
  --- WebCoreBridge.h	26 Jul 2005 16:34:13 -0000	1.341
  +++ WebCoreBridge.h	26 Jul 2005 17:37:21 -0000	1.342
  @@ -591,7 +591,7 @@
   - (void)textDidChangeInTextField:(DOMHTMLInputElement *)element;
   - (void)textDidChangeInTextArea:(DOMHTMLTextAreaElement *)element;
   
  -- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector;
  +- (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector;
   - (BOOL)textField:(DOMHTMLInputElement *)element shouldHandleEvent:(NSEvent *)event;
   
   - (NSView <WebCoreFileButton> *)fileButtonWithDelegate:(id <WebCoreFileButtonDelegate>)delegate;
  
  
  
  1.3259    +16 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3258
  retrieving revision 1.3259
  diff -u -r1.3258 -r1.3259
  --- ChangeLog	26 Jul 2005 16:34:14 -0000	1.3258
  +++ ChangeLog	26 Jul 2005 17:37:22 -0000	1.3259
  @@ -1,3 +1,19 @@
  +2005-07-26  John Sullivan  <sullivan at apple.com>
  +
  +        Reviewed by Chris Blumenberg.
  +        
  +        - more work to wean form-related SPI from NSView. All that's left (but this is a big "all")
  +        is viewForElement: and elementForView:        
  +
  +        * WebCoreSupport.subproj/WebBridge.m:
  +        (-[WebBridge textField:doCommandBySelector:]):
  +        changed signature to pass along DOMElement* rather than NSView*
  +        
  +        * WebView.subproj/WebFormDelegate.h:
  +        * WebView.subproj/WebFormDelegate.m:
  +        (-[WebFormDelegate textField:doCommandBySelector:inFrame:]):
  +        ditto
  +
   2005-07-25  John Sullivan  <sullivan at apple.com>
   
           Reviewed by Darin Adler.
  
  
  
  1.364     +3 -3      WebKit/WebCoreSupport.subproj/WebBridge.m
  
  Index: WebBridge.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebBridge.m,v
  retrieving revision 1.363
  retrieving revision 1.364
  diff -u -r1.363 -r1.364
  --- WebBridge.m	26 Jul 2005 16:34:16 -0000	1.363
  +++ WebBridge.m	26 Jul 2005 17:37:24 -0000	1.364
  @@ -1253,10 +1253,10 @@
       [formDelegate(self) textDidChangeInTextArea:element inFrame:_frame];
   }
   
  -- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector
  +- (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector
   {
  -    FormDelegateLog(control);
  -    return [formDelegate(self) control:control textView:textView doCommandBySelector:commandSelector inFrame:_frame];
  +    FormDelegateLog(element);
  +    return [formDelegate(self) textField:element doCommandBySelector:commandSelector inFrame:_frame];
   }
   
   - (BOOL)textField:(DOMHTMLInputElement *)element shouldHandleEvent:(NSEvent *)event
  
  
  
  1.14      +1 -1      WebKit/WebView.subproj/WebFormDelegate.h
  
  Index: WebFormDelegate.h
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebFormDelegate.h,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- WebFormDelegate.h	26 Jul 2005 16:34:17 -0000	1.13
  +++ WebFormDelegate.h	26 Jul 2005 17:37:25 -0000	1.14
  @@ -61,7 +61,7 @@
   - (void)textDidChangeInTextField:(DOMHTMLInputElement *)element inFrame:(WebFrame *)frame;
   - (void)textDidChangeInTextArea:(DOMHTMLTextAreaElement *)element inFrame:(WebFrame *)frame;
   
  -- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
  +- (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
   - (BOOL)textField:(DOMHTMLInputElement *)element shouldHandleEvent:(NSEvent *)event inFrame:(WebFrame *)frame;
   
   // Sent when a form is just about to be submitted (before the load is started)
  
  
  
  1.15      +1 -1      WebKit/WebView.subproj/WebFormDelegate.m
  
  Index: WebFormDelegate.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebView.subproj/WebFormDelegate.m,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- WebFormDelegate.m	26 Jul 2005 16:34:17 -0000	1.14
  +++ WebFormDelegate.m	26 Jul 2005 17:37:25 -0000	1.15
  @@ -53,7 +53,7 @@
   
   - (void)textDidChangeInTextArea:(DOMHTMLTextAreaElement *)element inFrame:(WebFrame *)frame { }
   
  -- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame
  +- (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame
   {
       return NO;
   }
  
  
  



More information about the webkit-changes mailing list