[webkit-changes] cvs commit: WebKit/WebView.subproj
WebFormDelegate.h WebFormDelegate.m
John
sullivan at opensource.apple.com
Wed Jul 20 15:55:08 PDT 2005
sullivan 05/07/20 15:55:07
Modified: . ChangeLog
kwq KWQTextField.mm WebCoreBridge.h
. ChangeLog
WebCoreSupport.subproj WebBridge.m
WebView.subproj WebFormDelegate.h WebFormDelegate.m
Log:
WebCore:
Reviewed by Vicki Murley.
- removed some form-related methods that weren't being used anywhere, in preparation
for weaning WebKit's WebFormDelegate protocol from NSView.
Test cases added: none, no behavior change
* kwq/KWQTextField.mm:
* kwq/WebCoreBridge.h:
removed these methods:
-control:didFailToFormatString:errorDescription:
-control:didFailToValidatePartialString:errorDescription:
-control:isValidObject:
WebKit:
Reviewed by Vicki Murley.
- removed some form-related methods that weren't being used anywhere, in preparation
for weaning WebKit's WebFormDelegate protocol from NSView.
* WebCoreSupport.subproj/WebBridge.m:
* WebView.subproj/WebFormDelegate.h:
* WebView.subproj/WebFormDelegate.m:
removed these methods:
-control:didFailToFormatString:errorDescription:
-control:didFailToValidatePartialString:errorDescription:
-control:isValidObject:
Revision Changes Path
1.4453 +16 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.4452
retrieving revision 1.4453
diff -u -r1.4452 -r1.4453
--- ChangeLog 20 Jul 2005 19:55:08 -0000 1.4452
+++ ChangeLog 20 Jul 2005 22:54:55 -0000 1.4453
@@ -1,3 +1,19 @@
+2005-07-20 John Sullivan <sullivan at apple.com>
+
+ Reviewed by Vicki Murley.
+
+ - removed some form-related methods that weren't being used anywhere, in preparation
+ for weaning WebKit's WebFormDelegate protocol from NSView.
+
+ Test cases added: none, no behavior change
+
+ * kwq/KWQTextField.mm:
+ * kwq/WebCoreBridge.h:
+ removed these methods:
+ -control:didFailToFormatString:errorDescription:
+ -control:didFailToValidatePartialString:errorDescription:
+ -control:isValidObject:
+
2005-07-20 Adele Peterson <adele at apple.com>
Rolling fix for <rdar://problem/4046602> back in.
1.82 +0 -27 WebCore/kwq/KWQTextField.mm
Index: KWQTextField.mm
===================================================================
RCS file: /cvs/root/WebCore/kwq/KWQTextField.mm,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -r1.81 -r1.82
--- KWQTextField.mm 20 Jul 2005 18:17:31 -0000 1.81
+++ KWQTextField.mm 20 Jul 2005 22:55:00 -0000 1.82
@@ -222,33 +222,6 @@
return [bridge control:control textShouldEndEditing:fieldEditor];
}
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error
-{
- if (!widget)
- return NO;
-
- WebCoreBridge *bridge = KWQKHTMLPart::bridgeForWidget(widget);
- return [bridge control:control didFailToFormatString:string errorDescription:error];
-}
-
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error
-{
- if (!widget)
- return;
-
- WebCoreBridge *bridge = KWQKHTMLPart::bridgeForWidget(widget);
- [bridge control:control didFailToValidatePartialString:string errorDescription:error];
-}
-
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj
-{
- if (!widget)
- return NO;
-
- WebCoreBridge *bridge = KWQKHTMLPart::bridgeForWidget(widget);
- return [bridge control:control isValidObject:obj];
-}
-
- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector
{
if (!widget)
1.339 +0 -3 WebCore/kwq/WebCoreBridge.h
Index: WebCoreBridge.h
===================================================================
RCS file: /cvs/root/WebCore/kwq/WebCoreBridge.h,v
retrieving revision 1.338
retrieving revision 1.339
diff -u -r1.338 -r1.339
--- WebCoreBridge.h 14 Jul 2005 23:53:34 -0000 1.338
+++ WebCoreBridge.h 20 Jul 2005 22:55:00 -0000 1.339
@@ -590,9 +590,6 @@
- (BOOL)control:(NSControl *)control textShouldBeginEditing:(NSText *)fieldEditor;
- (BOOL)control:(NSControl *)control textShouldEndEditing:(NSText *)fieldEditor;
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error;
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error;
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj;
- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector;
- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView shouldHandleEvent:(NSEvent *)event;
1.3243 +15 -0 WebKit/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebKit/ChangeLog,v
retrieving revision 1.3242
retrieving revision 1.3243
diff -u -r1.3242 -r1.3243
--- ChangeLog 20 Jul 2005 20:36:35 -0000 1.3242
+++ ChangeLog 20 Jul 2005 22:55:01 -0000 1.3243
@@ -1,3 +1,18 @@
+2005-07-20 John Sullivan <sullivan at apple.com>
+
+ Reviewed by Vicki Murley.
+
+ - removed some form-related methods that weren't being used anywhere, in preparation
+ for weaning WebKit's WebFormDelegate protocol from NSView.
+
+ * WebCoreSupport.subproj/WebBridge.m:
+ * WebView.subproj/WebFormDelegate.h:
+ * WebView.subproj/WebFormDelegate.m:
+ removed these methods:
+ -control:didFailToFormatString:errorDescription:
+ -control:didFailToValidatePartialString:errorDescription:
+ -control:isValidObject:
+
2005-07-20 Adele Peterson <adele at apple.com>
Merged fix for:
1.362 +0 -18 WebKit/WebCoreSupport.subproj/WebBridge.m
Index: WebBridge.m
===================================================================
RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebBridge.m,v
retrieving revision 1.361
retrieving revision 1.362
diff -u -r1.361 -r1.362
--- WebBridge.m 19 Jul 2005 17:11:55 -0000 1.361
+++ WebBridge.m 20 Jul 2005 22:55:06 -0000 1.362
@@ -1265,24 +1265,6 @@
return [formDelegate(self) control:control textShouldEndEditing:fieldEditor inFrame:_frame];
}
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error
-{
- FormDelegateLog(control);
- return [formDelegate(self) control:control didFailToFormatString:string errorDescription:error inFrame:_frame];
-}
-
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error
-{
- FormDelegateLog(control);
- [formDelegate(self) control:control didFailToValidatePartialString:string errorDescription:error inFrame:_frame];
-}
-
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj
-{
- FormDelegateLog(control);
- return [formDelegate(self) control:control isValidObject:obj inFrame:_frame];
-}
-
- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector
{
FormDelegateLog(control);
1.12 +0 -3 WebKit/WebView.subproj/WebFormDelegate.h
Index: WebFormDelegate.h
===================================================================
RCS file: /cvs/root/WebKit/WebView.subproj/WebFormDelegate.h,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- WebFormDelegate.h 5 Jun 2005 17:54:46 -0000 1.11
+++ WebFormDelegate.h 20 Jul 2005 22:55:07 -0000 1.12
@@ -61,9 +61,6 @@
- (BOOL)control:(NSControl *)control textShouldBeginEditing:(NSText *)fieldEditor inFrame:(WebFrame *)frame;
- (BOOL)control:(NSControl *)control textShouldEndEditing:(NSText *)fieldEditor inFrame:(WebFrame *)frame;
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error inFrame:(WebFrame *)frame;
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error inFrame:(WebFrame *)frame;
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj inFrame:(WebFrame *)frame;
- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView shouldHandleEvent:(NSEvent *)event inFrame:(WebFrame *)frame;
1.13 +0 -14 WebKit/WebView.subproj/WebFormDelegate.m
Index: WebFormDelegate.m
===================================================================
RCS file: /cvs/root/WebKit/WebView.subproj/WebFormDelegate.m,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- WebFormDelegate.m 5 Jun 2005 17:54:46 -0000 1.12
+++ WebFormDelegate.m 20 Jul 2005 22:55:07 -0000 1.13
@@ -63,20 +63,6 @@
return YES;
}
-- (BOOL)control:(NSControl *)control didFailToFormatString:(NSString *)string errorDescription:(NSString *)error inFrame:(WebFrame *)frame
-{
- return YES;
-}
-
-- (void)control:(NSControl *)control didFailToValidatePartialString:(NSString *)string errorDescription:(NSString *)error inFrame:(WebFrame *)frame
-{
-}
-
-- (BOOL)control:(NSControl *)control isValidObject:(id)obj inFrame:(WebFrame *)frame
-{
- return YES;
-}
-
- (BOOL)control:(NSControl *)control textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame
{
return NO;
More information about the webkit-changes
mailing list